Repository navigation
fix: preserve Duo toolbar buttons behind modals - #324
Merged
Merged
Conversation
Contributor
Playwright test resultsDetails
Flaky testschromium › native-ui.spec.ts › horizontal tabs retain measured native width on Web handoff without feeding it back |
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-324/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
…-handoff # Conflicts: # demo/e2e/native-ui.spec.ts
…-handoff # Conflicts: # demo/e2e/native-ui.spec.ts
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@2.0.2-beta.pr324.sha95e12dbfe5f9 @rdlabo/capacitor-native-ui@2.0.2-beta.pr324.sha95e12dbfe5f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a modal on Duo removed the covered page's vertical-bar buttons instead of handing them back to Web projection. Keep each covered button or group on its own surface, aligned to native measurements, and restore foreground/native ownership after dismissal.
Covered projections are inert and hidden from accessibility; delayed clicks cannot activate the underlying page. Disabled state follows the source. Account for the group border when translating native item coordinates to avoid a 1px handoff shift.
Edge-case verification also found that collapsing an ion-buttons group after projecting its Ionic children hid a remaining explicit HTML button. Collapse the group only when no unprojected element children remain. This preserves mixed automatic and data-native-ui ownership without adding runtime machinery.
Validation:
Final local integration of #323, #324 and #325 passed 157 unit tests, 26 Chromium/WebKit edge tests, TypeScript checking, CSS/native package builds and workspace lint. Native width measurement also passed on both iPhone and Duo simulators. No additional runtime changes were needed after integration.