Skip to content

fix: apply selection tint to SwiftUI vertical tabs - #322

Merged
rdlabo merged 2 commits into
mainfrom
fix/vertical-tabs-selection-tint
Oct 23, 2026
Merged

rdlabo merged 2 commits into
mainfrom
fix/vertical-tabs-selection-tint

Conversation

@rdlabo

@rdlabo rdlabo commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Duo Vertical Bars kept showing the system blue selection color even when the Web snapshot supplied the correct tabTint (for example, rgb(91, 63, 214)). Setting UITabBar.tintColor alone did not update the visible SwiftUI rail.

Apply the selection tint to the SwiftUI TabView and reset the page tint so toolbar/search controls keep their own accent. Keep the existing UIKit appearance handling.

Extend the native regression test to check the tab controller’s effective tint as well as the legacy tab-bar property. Compare resolved RGBA components to tolerate SwiftUI color-space conversion.

Validation:

  • The extended regression test fails against the unmodified 2.0.2-1 implementation.
  • Built the consuming app and verified on iPhone Duo / iOS 27.1: the selected tab renders purple; toolbar controls remain black.
  • Full native Swift test suite: 59 tests passed on iPhone Duo / iOS 27.1.

@github-actions

Copy link
Copy Markdown
Contributor

Playwright test results

passed  483 passed
flaky  1 flaky

Details

stats  484 tests across 25 suites
duration  5 minutes, 19 seconds
commit  e4df6c7
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

Flaky tests

chromium › segment.spec.ts › short taps preserve outward velocity and do not shorten the container return

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-322/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo
rdlabo merged commit 8d25e1f into main Oct 23, 2026
22 of 24 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit 8d25e1f814dd. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios27@2.0.2-beta.pr322.sha8d25e1f814dd @rdlabo/capacitor-native-ui@2.0.2-beta.pr322.sha8d25e1f814dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant