Repository navigation
fix: apply selection tint to SwiftUI vertical tabs - #322
Merged
Merged
Conversation
Contributor
Playwright test resultsDetails
Flaky testschromium › segment.spec.ts › short taps preserve outward velocity and do not shorten the container return |
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-322/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@2.0.2-beta.pr322.sha8d25e1f814dd @rdlabo/capacitor-native-ui@2.0.2-beta.pr322.sha8d25e1f814dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duo Vertical Bars kept showing the system blue selection color even when the Web snapshot supplied the correct
tabTint(for example,rgb(91, 63, 214)). SettingUITabBar.tintColoralone did not update the visible SwiftUI rail.Apply the selection tint to the SwiftUI
TabViewand reset the page tint so toolbar/search controls keep their own accent. Keep the existing UIKit appearance handling.Extend the native regression test to check the tab controller’s effective tint as well as the legacy tab-bar property. Compare resolved RGBA components to tolerate SwiftUI color-space conversion.
Validation: