Repository navigation
fix: use applied selection color for native Vertical Bars tabs - #321
Merged
Merged
Conversation
Contributor
Playwright test results
Details
|
rdlabo
changed the title
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-321/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertical Bars tabs currently use the system selection tint even when Ionic applies a custom selected-tab color. Read the selected tab button's existing computed foreground color and pass it to the native tab bar. This follows Ionic's
--color-selected, per-tab overrides and light/dark theme changes without requiring a separate RGB palette token or adding color-measurement DOM.Keep normal/disabled colors, labels, glass backgrounds and toolbar/search controls under native styling. Tab bars using Ionic's
colorpalette retain the system tint because their contrast foreground assumes a colored Web background. Missing selection or unsupported computed color formats also use the system tint. Reapply the tint if SwiftUI resets it during tab reconstruction. The snapshot field is optional for backward compatibility.Validation:
--color-selected, per-tab overrides,light-dark(),currentColor, alpha, palette exceptions, existing tab navigation and SVG/theme behavior.