Repository navigation
fix: coordinate native tab toolbar handoffs and prevent Duo Search FAB flashes - #320
Merged
Merged
Conversation
Contributor
Playwright test results
Details
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report after GitHub Pages deployment completes: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-320/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@2.0.1-beta.pr320.sha1504df298a37 @rdlabo/capacitor-native-ui@2.0.1-beta.pr320.sha1504df298a37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native tab switches could leave the previous page’s toolbar over the destination while projection waited for layout or icon decoding. Retire outgoing page controls before forwarding tab activation to Ionic, while keeping shared tab controls native. The shared runtime handles horizontal and vertical toolbars, rapid selection, and rejected navigation without changing push/back identity matching.
On Duo, entering Library could briefly show the original Web Search FAB before its native replacement appeared. Hide the entering FAB until projection settles, and prevent stale acknowledgements from releasing it early. Retain Web source ownership while native Search remains visible on departure, while respecting search opt-outs and restoring Web fallback when native search is rejected.
Validation: