Skip to content

Export as ES module #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shirte wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Export as ES module #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
863e46a
Remove duplicate build instructions
shirte Jun 1, 2026
010e944
Compile webassembly wrapper as an ES module
shirte Jun 5, 2026
d168c73
Modernize wrapper code
shirte May 30, 2026
d407bd5
Write generated files to typescript folder
shirte Jun 5, 2026
6ee8632
Export as ES6 module
shirte May 29, 2026
b89e668
Use tsup for compiling / bundling
shirte Jun 5, 2026
0577347
Use local rdkit-js version in example projects
shirte Jun 6, 2026
6957dd9
Simplify angularjs example
shirte Jun 5, 2026
1758382
Simplify nextjs example
shirte Jun 5, 2026
9bc92b1
Simplify node example
shirte May 29, 2026
2aa3cfb
Simplify react example
shirte May 30, 2026
609efda
Simplify vue example
shirte Jun 5, 2026
0bc40a4
Fix race condition in nextjs example
shirte Jun 1, 2026
2f8fc25
Adapt build script
shirte Jun 5, 2026
f6fb60e
Enable passing EMSDK_VERSION to build script
shirte Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ RUN sed -i 's|^\( *\)\(GenericStringRef\& operator=(const GenericStringRef\& rhs
RUN make -j2 RDKit_minimal && \
cp Code/MinimalLib/RDKit_minimal.* ../Code/MinimalLib/demo/

# Build the ESM version (using the cached CMake configuration from the previous build). The linker
# flags are the same as for the non-ESM version, except "-s EXPORT_ES6=1" at the end.
RUN emcmake cmake -DCMAKE_EXE_LINKER_FLAGS="${EXCEPTION_HANDLING} -s STACK_OVERFLOW_CHECK=1 -s USE_PTHREADS=0 -s ALLOW_MEMORY_GROWTH=1 -s MAXIMUM_MEMORY=4GB -s MODULARIZE=1 -s EXPORT_NAME=\"'initRDKitModule'\" -s EXPORT_ES6=1" .. && \
make -j2 RDKit_minimal && \
cp Code/MinimalLib/RDKit_minimal.js ../Code/MinimalLib/demo/RDKit_minimal_esm.js

# run the tests
WORKDIR /src/rdkit/Code/MinimalLib/tests
RUN /opt/emsdk/node/*/bin/node tests.js
Expand Down
17 changes: 12 additions & 5 deletions examples/angular/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
"version": 1,
"cli": {
"packageManager": "yarn",
"schematicCollections": ["@angular-eslint/schematics"],
"schematicCollections": [
"@angular-eslint/schematics"
],
"analytics": false
},
"newProjectRoot": "projects",
Expand Down Expand Up @@ -54,12 +56,14 @@
"src/assets",
{
"glob": "RDKit_minimal.wasm",
"input": "node_modules/@rdkit/rdkit/dist/",
"input": "node_modules/@rdkit/rdkit/dist/esm",
"output": "/"
}
],
"styles": ["src/styles.css"],
"scripts": ["node_modules/@rdkit/rdkit/dist/RDKit_minimal.js"],
"styles": [
"src/styles.css"
],
"scripts": [],
"vendorChunk": true,
"extractLicenses": false,
"buildOptimizer": false,
Expand Down Expand Up @@ -118,7 +122,10 @@
"lint": {
"builder": "@angular-eslint/builder:lint",
"options": {
"lintFilePatterns": ["src/**/*.ts", "src/**/*.html"]
"lintFilePatterns": [
"src/**/*.ts",
"src/**/*.html"
]
}
}
}
Expand Down
Loading