-
Notifications
You must be signed in to change notification settings - Fork 4
Indexed #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rchillyard
wants to merge
20
commits into
master
Choose a base branch
from
Indexed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Indexed #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsvRenderer: CSV operations now all required parametric type T to have Ordering; Content: added ordered method (like sorted but returns Seq[S]); Sequential: new module to support indexed (sequential) tables; Table: toCSV and related methods: require Ordering[T]; (example) Crime: * extends Sequential; * split into two case classes (one is CrimeLocation);
Crime data: removed first six rows Content: * new method noOrdering (moved from Sequential, where it was called randomOrdering); * updated sorted, ordered to pay attention to noOrdering; * added sample method; Sequential: * new trait OrderingWithZero; * moved randomOrdering to Content (name change); * optionOrdering and tryOrdering now require OrderingWithZero evidence rather than Numeric evidence; * tryOrdering completed and tested; SelectiveParser: added to RowParser to define setForgiving and setPredicate. Crime: added Main program.
Analysis: * Column: takes Analytic instead of Statistics * minor name changes
Analysis: Analytic: added method total: Int; Table: added filterValid; Validity: new trait; Crime: update to use Validity.
Crime: * location is now an Option; * optional fields are now called "maybe..."; CrimeLocation: * lat/long are non options now; CrimeBrief: crimeID is no longer optional. CsvGenerators: * dded method optionProduct * now strip maybe from name.
Also reverted main program checking validity of CrimeLocation elements.
TableParser: renamed ImplicitParser.doParse as parser. Analysis: reworked main program.
Upgraded version of cats-effect A few other minor refactorings.
Crime: use IO instead of Try for resource definitions
FP: added methods ioResource and ioResourceForClass;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits is mostly concerned with providing an index into a table.