test: cover untested signature-verification branches in Utility#332
Open
eeshsaxena wants to merge 1 commit into
Open
test: cover untested signature-verification branches in Utility#332eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
Adds tests for the timing-safe compare_string helper (equal, differing content, differing length), for verify_payment_link_signature returning False when required keys are absent, and for the failure path of verify_subscription_payment_signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Utilitysignature helpers had a few untested branches, including some that are security-relevant. This adds coverage for them:compare_string— the constant-time string comparison used as the pre-hmac.compare_digestfallback. Tests equal strings, equal-length-but-differing content, and differing lengths. It had no tests at all.verify_payment_link_signature— the branch that returnsFalsewhenpayment_link_reference_id/payment_link_statusare absent (the existing test only exercised the fully-populated happy path).verify_subscription_payment_signature— its failure path, assertingSignatureVerificationErroris raised on a bad signature (only the success case was covered before).Tests only — no library code changed.
tests/test_client_utility.pypasses (11 passed).