Skip to content

Repair settings paths left behind by a moved tool folder #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
razbenaharon merged 1 commit into from
Nov 9, 2026
Merged

Repair settings paths left behind by a moved tool folder #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions DevDriveBackup.Data.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,22 @@ function Read-CenterProfiles {
if(-not(Test-Path -LiteralPath $p)){return [pscustomobject]@{Version=1;Profiles=@()}}
$data=Get-Content -LiteralPath $p -Raw|ConvertFrom-Json
$data.Profiles=@($data.Profiles|ForEach-Object {$_.Sources=@($_.Sources);$_})
# A source's settings file is stored by full path. When the tool folder is moved or renamed, that path
# goes stale; a file of the same name in the jobs folder or beside the profiles file is the same file, moved.
$moved=$false
foreach($s in @($data.Profiles|ForEach-Object {$_.Sources})){
$old=[string]$s.ConfigPath
if(-not $old -or (Test-Path -LiteralPath $old)){continue}
$leaf=Split-Path $old -Leaf
foreach($dir in @((Get-CenterPaths).Jobs,[IO.Path]::GetDirectoryName($p))){
$candidate=Join-Path $dir $leaf
if(-not(Test-Path -LiteralPath $candidate -PathType Leaf)){continue}
# Same name is not proof: the file must describe this very source (its folder and its plain copy folder).
$same=try{$job=Get-Content -LiteralPath $candidate -Raw|ConvertFrom-Json;[string]$job.Source -ieq [string]$s.Path -and [string]$job.MirrorFolder -ieq [string]$s.MirrorFolder}catch{$false}
if($same){$s.ConfigPath=$candidate;$moved=$true;break}
}
}
if($moved){Save-CenterProfiles $data}
$data
}
function Save-CenterProfiles($Data) {
Expand Down
8 changes: 8 additions & 0 deletions Test-DevDriveBackup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ try{
$s=Add-CenterSource -Data $data -ProfileId $p.Id -Path $source -Label $label -DefaultMode Both
Save-CenterProfiles $data
$created+=Join-Path ($DestinationDrive+':\') $s.MirrorFolder
$real=$s.ConfigPath;$s.ConfigPath=Join-Path (Join-Path $dataRoot 'OldToolName') (Split-Path $real -Leaf);Save-CenterProfiles $data
Assert ((Get-Content -LiteralPath (Get-CenterPaths).Profiles -Raw) -match 'OldToolName') 'a stale settings path is on disk before the repair'
$data=Read-CenterProfiles;$p=Get-CenterProfile $data $p.Id;$s=@($p.Sources)[0]
Assert ($s.ConfigPath -eq $real -and (Get-Content -LiteralPath (Get-CenterPaths).Profiles -Raw) -notmatch 'OldToolName') 'a settings path left behind by a moved or renamed tool folder is repaired and saved'
$s.MirrorFolder='Other-Mirror';$s.ConfigPath=Join-Path (Join-Path $dataRoot 'OldToolName') (Split-Path $real -Leaf);Save-CenterProfiles $data
$data=Read-CenterProfiles;$p=Get-CenterProfile $data $p.Id;$s=@($p.Sources)[0]
Assert ($s.ConfigPath -ne $real) 'a file of the same name that describes another source is not taken'
$s.MirrorFolder=Split-Path $created[-1] -Leaf;$s.ConfigPath=$real;Save-CenterProfiles $data
$job=Read-CenterJob $s.ConfigPath
$created+=Join-Path ($DestinationDrive+':\') $job.RepositoryFolder
Assert (@($job.Choices).Count -eq 2 -and @($job.Choices|Where-Object {$_.Mode -ne 'Both'}).Count -eq 0) 'new source lists its top-level folders with the chosen mode'
Expand Down