Skip to content

Fix five serious findings from the repository review - #1

Merged
razbenaharon merged 1 commit into
mainfrom
repo-validation-fixes
Nov 7, 2026
Merged

razbenaharon merged 1 commit into
mainfrom
repo-validation-fixes

Conversation

@razbenaharon

Copy link
Copy Markdown
Owner

Fixes five serious findings from the repository review before the repository goes public, and brings the docs and CI back in line with the code.

Fixes

  • Plain copy never copies a private password/recovery-key folder or key file, also when it is itself the selected folder or file. Older private copies in the mirror are reported.
  • A new source never gets the plain copy or versions folder of a removed source of the same drive, also while the drive is unplugged.
  • Before the drive check asks for administrator rights, the window checks who could change what it runs or rename a folder above it, and asks first. smartctl runs only when its SHA-256 matches the official 7.5 build.
  • The drive check judges the newest short and long self-test each on its own, so a passing short test no longer hides a failed one.
  • Keep versions deletes, then frees space in a separate step; a failed repository check after the clean-up now fails the backup.

Maintenance

  • README, BACKUP-SYSTEM.md, CHANGELOG and THIRD-PARTY match the code again.
  • CI uses actions/checkout@v7, builds Backup.Taskbar.cs and runs Test-BackupResourceControls.ps1.
  • New tests cover each fix; two tests no longer leave empty folders in %TEMP%.

🤖 Generated with Claude Code

…CI up to date

Fixes:
- Plain copy never copies a private password/recovery-key folder or key file,
  also when it is itself the selected folder or file (robocopy applies /XD only
  below the folder it copies). Older private copies in the mirror are reported.
- A new source never gets the plain copy or versions folder of a removed source
  of the same drive, also while the drive is unplugged; a removed job is not
  adopted when a current source uses its repository.
- Before the drive check asks for administrator rights, the window checks who
  could change what it runs or rename a folder above it (links included) and
  asks first. smartctl runs only when its SHA-256 matches the official 7.5
  build and is held open while it runs; the installer is held open from its
  checksum check until it has run.
- The drive check judges the newest short and long self-test that passed or
  failed each on its own, so a passing short test no longer hides a failed one.
- Keep versions deletes, then frees space in a separate step, and a failed
  repository check after the clean-up now fails the backup.

Maintenance:
- README, BACKUP-SYSTEM.md, CHANGELOG and THIRD-PARTY match the code again.
- CI uses actions/checkout@v7, builds Backup.Taskbar.cs and runs
  Test-BackupResourceControls.ps1.
- New-DevDriveBackupIcon.ps1 draws the current icon from design/icon.
- Two tests no longer leave empty folders in %TEMP%; new tests cover each fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@razbenaharon
razbenaharon merged commit bc736f7 into main Nov 7, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant