Repository navigation
chore(proto): pull blockers on OrganizationToLeave - #2026
Conversation
Pins PROTON_COMMIT to 4e9e25ed, the commit in raystack/proton#504, which adds blockers to CheckCurrentUserDeleteResponse.OrganizationToLeave.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update Proton commit pin Makefile |
The proto target now references the new Proton commit. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Other
Possibly related PRs
- raystack/frontier#2025: This PR updates Proton for the delete-check RPC; this change pins Frontier to a Proton commit that adds the referenced field.
Suggested reviewers: rohilsurana
Merge Risk: 
Minimal · up to 012c9
-
The generated protobuf update is mergeable with no remaining review-blocking risk.
Pre-merge checks: 
2
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Coverage Report for CI Build 40651906009Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.05%) to 55.78%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions168 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
Summary
Pins
PROTON_COMMITto 94668c36, the commit on proton main from raystack/proton#504, and regeneratesproto/v1beta1. No handler logic changes.Changes
CheckCurrentUserDeleteResponse.OrganizationToLeavegainsblockers.CheckCurrentUserDeletehas no handler yet, so nothing sets it.frontier.pb.gochanges. Besides the new field and its getter, its diff is the proto definition that the file stores as bytes. The new field shifts every row after it.Test Plan
go build ./...andgo vet ./proto/... ./internal/api/v1beta1connect/...go test -race ./internal/api/v1beta1connect/... ./pkg/server/... ./core/deleter/...make lintmake protoat the old pin (680ef693) gives the committed files byte for byte, so the whole diff comes from the new fieldmake protoat the new pin (94668c36) gives the committed files byte for byte