Skip to content

chore(proto): pull blockers on OrganizationToLeave - #2026

Merged
AmanGIT07 merged 2 commits into
mainfrom
chore/bump-proton-org-to-leave-blockers
Oct 29, 2026
Merged

AmanGIT07 merged 2 commits into
mainfrom
chore/bump-proton-org-to-leave-blockers

Conversation

@AmanGIT07

@AmanGIT07 AmanGIT07 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pins PROTON_COMMIT to 94668c36, the commit on proton main from raystack/proton#504, and regenerates proto/v1beta1. No handler logic changes.

Changes

  • CheckCurrentUserDeleteResponse.OrganizationToLeave gains blockers. CheckCurrentUserDelete has no handler yet, so nothing sets it.
  • Only frontier.pb.go changes. Besides the new field and its getter, its diff is the proto definition that the file stores as bytes. The new field shifts every row after it.

Test Plan

  • go build ./... and go vet ./proto/... ./internal/api/v1beta1connect/...
  • go test -race ./internal/api/v1beta1connect/... ./pkg/server/... ./core/deleter/...
  • make lint
  • make proto at the old pin (680ef693) gives the committed files byte for byte, so the whole diff comes from the new field
  • make proto at the new pin (94668c36) gives the committed files byte for byte

Pins PROTON_COMMIT to 4e9e25ed, the commit in raystack/proton#504, which
adds blockers to CheckCurrentUserDeleteResponse.OrganizationToLeave.
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
frontier Ready Ready Preview Oct 28, 2026 7:45am UTC

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 302a6d3 and 012c9d5.

Files selected for processing: 1
  • Makefile

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the source revision used for protobuf generation. This may update the protocol definitions produced by the project’s generation process; no direct changes to user-facing features or behavior are included.

The proto target now uses Proton commit 94668c362cad03165629c14c7b1abf753e885496 instead of 680ef693ec1059e996f6a92e6936a56d1a8ac1cd.

Changes: Protobuf Generation

Layer / File(s) Summary
Update Proton commit pin
Makefile
The proto target now references the new Proton commit.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • raystack/frontier#2025: This PR updates Proton for the delete-check RPC; this change pins Frontier to a Proton commit that adds the referenced field.

Suggested reviewers: rohilsurana

Merge Risk: Minimal · up to 012c9

The generated protobuf update is mergeable with no remaining review-blocking risk.

Pre-merge checks: Passed 2
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

coveralls commented Oct 26, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 40651906009

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.05%) to 55.78%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 168 coverage regressions across 5 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

168 previously-covered lines in 5 files lost coverage.

File Lines Losing Coverage Coverage
core/deleter/service.go 51 84.66%
core/user/service.go 43 70.07%
internal/api/v1beta1connect/organization.go 36 63.35%
internal/store/postgres/organization_repository.go 32 79.31%
core/membership/service.go 6 88.82%

Coverage Stats

Coverage Status
Relevant Lines: 41943
Covered Lines: 23396
Line Coverage: 55.78%
Coverage Strength: 19.57 hits per line

💛 - Coveralls

Comment thread Makefile Outdated
@AmanGIT07
AmanGIT07 merged commit e1765e7 into main Oct 29, 2026
8 checks passed
@AmanGIT07
AmanGIT07 deleted the chore/bump-proton-org-to-leave-blockers branch October 29, 2026 07:19

This branch was successfully deployed

1 active deployment
Preview — 012c9d5d Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants