[AmanGIT07]

Summary

user.Service.Delete now ends the user's sessions after it removes the user's relations and before it deletes the user row. Today the sessions go only because sessions.user_id references users with ON DELETE CASCADE, which fires on the hard delete. #2023 makes the user delete keep the row, so that cascade stops firing. Without this change, a request with a deleted user's session cookie would get not found instead of unauthenticated. This PR should be merged before #2023.

Changes

• core/user/service.go: Delete calls sessionService.DeleteByUserID, the same call Disable makes, between the relations and the row. A failure stops the delete before the row.

Technical Details

• The sessions end as the last step before the row, which is when the cascade ends them today. If an earlier step fails, the user row is still live and the user stays signed in, so they can retry.
• DeleteByUserID sets deleted_at on each live session of the user. A session with deleted_at set fails Session.IsValid, so the session authenticator skips it and the request is unauthenticated.
• When an admin deletes a user, each live session gets a session.revoked audit record, as with DisableUser. No record is written when the actor is the session owner.
• The expired session cleanup later removes these rows, 24 hours after deleted_at.

Test Plan

• core/user/service_test.go TestService_Delete: the relations go first, then the sessions, then the user row; a relation failure stops the delete before the sessions and the user; a session failure stops it before the user. The cases fail without the session step, with the step before the relations or after the row, or with its error ignored.
• e2e TestUserAPI case 13: a logged-in user is deleted by an admin, and the same session cookie then gets unauthenticated. On main this passes without the change too, because the hard delete still removes the sessions. With feat(store): user delete keeps the row #2023's soft delete applied locally, it passes with this change and fails without it: the cookie gets not found instead of unauthenticated.
• go test ./core/user/... passes.
• go test ./test/e2e/... passes.
• golangci-lint run ./core/user/... ./test/e2e/regression/... reports no issues.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
frontier	Ready	Preview	Oct 27, 2026 11:43am UTC

[coderabbitai]

📝 Summary

Summary by CodeRabbit

• Bug Fixes
  • Deleting an account now also ends its active sessions. Requests made with those sessions are no longer authenticated after the account is deleted.

User deletion now removes the user’s relations, then sessions, and then the user record. Tests cover deletion order, failure handling, and session authentication after deletion.

Changes: User deletion

Layer / File(s)	Summary
Delete relations and sessions before the user record core/user/service.go, core/user/service_test.go	Service.Delete deletes sessions after relation deletion and before deleting the user. Unit tests verify this order and that failures stop later operations.
Check session after user deletion test/e2e/regression/api_test.go	The regression test verifies that a request using the deleted user’s session fails with Unauthenticated.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: kushsharma

Merge Risk: Low · up to 717de

User deletion can leave inaccurate revocation events for sessions that were already invalid.

Pre-merge checks: 2

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coveralls]

Coverage Report for CI Build 40498168490

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.01%) to 55.739%

Details

• Coverage increased (+0.01%) from the base build.
• Patch coverage: 3 of 3 lines across 1 file are fully covered (100%).
• 68 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

68 previously-covered lines in 2 files lost coverage.

File	Lines Losing Coverage	Coverage
internal/api/v1beta1connect/organization.go	36	63.35%
internal/store/postgres/organization_repository.go	32	79.31%

---

Coverage Stats

Relevant Lines:	41940
Covered Lines:	23377
Line Coverage:	55.74%
Coverage Strength:	19.5 hits per line

---

💛 - Coveralls

[coderabbitai]

Actionable comments posted: 1

---

Review info

Run configuration

• Source mode: Auto
• Repository: raystack/frontier
• Branch: fix/user-delete-ends-sessions
• File: .coderabbit.yaml
• Commit: 717deab
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 53066f08-b96b-4667-a2f6-3c9575e0b717

Commits

Reviewing files that changed from the base of the PR and between c60c015 and 717deab.

Files selected for processing: 2

• core/user/service.go
• core/user/service_test.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.