fix(consent): store no consent on a flow that can never record one - #1920
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 33784841320Coverage decreased (-0.08%) to 50.138%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions43 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Summary
flows.metadatawhenever a caller sentaccepted_document_ids, with no check on whether the deployment asks for consent, or whether the intent could ever produce a record.app.consentdisabled, and a login under any config, therefore persisted unvalidated client ids alongside the caller's IP and a timestamp under a key namedconsent— for a record that is never written.gateFlowConsentalready resolves the ids, so it now returns what they resolved to and the write is keyed off that. Nothing resolves with consent disabled, on a login, or with the service unwired, so none of the three carries a block.user_consentsandaudit_recordsneeded no change — both are reachable only through the branchcreateUsertakes whenResolveAllreturns documents, which is empty when consent is disabled.