Skip to content

chore(proto): bump proton to pick up pagination field bounds#1804

Merged
AmanGIT07 merged 1 commit into
mainfrom
chore/bump-proton-pagination-bounds
Jul 24, 2026
Merged

chore(proto): bump proton to pick up pagination field bounds#1804
AmanGIT07 merged 1 commit into
mainfrom
chore/bump-proton-pagination-bounds

Conversation

@AmanGIT07

Copy link
Copy Markdown
Contributor

Summary

Bumps PROTON_COMMIT to f90d337 and regenerates the protobuf code, picking up raystack/proton#492.

Changes

Technical Details

The bounds are enforced by the existing ConnectRPC validate interceptor; requests above the limit return invalid_argument.

Test Plan

  • Manual testing completed — over-limit page_size/limit return invalid_argument; at-limit and unset values succeed (verified on ListProjectsByCurrentUser, ListAllOrganizations, SearchUsers)
  • Build and type checking passes

🤖 Generated with Claude Code

Regenerates protobuf code at proton f90d337, adding buf.validate upper
bounds (lte 5000) on list request page_size fields and RQLRequest limit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Jul 24, 2026 9:47am

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 79ab2f02-d2f8-47ce-91b5-c3980e76d930

📥 Commits

Reviewing files that changed from the base of the PR and between 1c8b608 and 0f4124a.

⛔ Files ignored due to path filters (3)
  • proto/v1beta1/admin.pb.go is excluded by !**/*.pb.go, !proto/**
  • proto/v1beta1/frontier.pb.go is excluded by !**/*.pb.go, !proto/**
  • proto/v1beta1/models.pb.go is excluded by !**/*.pb.go, !proto/**
📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated internal build configuration to keep generated artifacts aligned with the latest supported service definitions.
    • No changes were made to application behavior, user-facing features, or existing build, lint, and test commands.
    • This update is expected to be transparent during normal use while improving consistency for future generated code and development workflows.

Walkthrough

The Makefile updates PROTON_COMMIT, changing the Proton revision fetched during the proto target’s buf generate step.

Changes

Proton revision update

Layer / File(s) Summary
Update protobuf source revision
Makefile
Changes PROTON_COMMIT to a new Git commit hash used during protobuf generation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: rohilsurana

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30083865417

Coverage remained the same at 46.866%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 38981
Covered Lines: 18269
Line Coverage: 46.87%
Coverage Strength: 14.33 hits per line

💛 - Coveralls

@AmanGIT07
AmanGIT07 requested a review from rohilsurana July 24, 2026 09:59
@AmanGIT07
AmanGIT07 merged commit 68774c3 into main Jul 24, 2026
8 checks passed
@AmanGIT07
AmanGIT07 deleted the chore/bump-proton-pagination-bounds branch July 24, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants