-
Notifications
You must be signed in to change notification settings - Fork 45
feat(db): block deleting an org that still has service users #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
...l/store/postgres/migrations/20260723120000_restrict_org_delete_with_serviceusers.down.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| DROP TRIGGER IF EXISTS trg_serviceusers_block_org_delete ON organizations; | ||
| DROP FUNCTION IF EXISTS serviceusers_block_org_delete(); |
26 changes: 26 additions & 0 deletions
26
...nal/store/postgres/migrations/20260723120000_restrict_org_delete_with_serviceusers.up.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| -- Block deleting an organization that still has service users. | ||
|
|
||
| -- A plain foreign key to organizations(id) cannot be used here. The bootstrap | ||
| -- superuser lives under the virtual platform org (00000000-0000-0000-0000-000000000000), | ||
| -- which has no row in organizations by design. A BEFORE DELETE trigger only | ||
| -- fires when a real org is deleted, so the virtual platform org and its | ||
| -- bootstrap service account are never in scope. | ||
| -- | ||
| -- Existing orphaned rows (if any) are left untouched; they are cleaned up out | ||
| -- of band, not by this migration. | ||
| CREATE OR REPLACE FUNCTION serviceusers_block_org_delete() | ||
| RETURNS trigger AS $$ | ||
| BEGIN | ||
| IF EXISTS (SELECT 1 FROM serviceusers WHERE org_id = OLD.id) THEN | ||
| RAISE EXCEPTION 'cannot delete organization %: service users still reference it', OLD.id | ||
| USING ERRCODE = 'foreign_key_violation'; | ||
| END IF; | ||
| RETURN OLD; | ||
| END; | ||
| $$ LANGUAGE plpgsql; | ||
|
|
||
| DROP TRIGGER IF EXISTS trg_serviceusers_block_org_delete ON organizations; | ||
| CREATE TRIGGER trg_serviceusers_block_org_delete | ||
| BEFORE DELETE ON organizations | ||
| FOR EACH ROW | ||
| EXECUTE FUNCTION serviceusers_block_org_delete(); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.