Feature/org design fixes#1787
Conversation
Hide the "New Organization" button (and its separator) while search is active so the listing navbar stays uncluttered, and align the navbar height with the org-details navbar (48px) instead of 56px.
Display org member roles as "Owner", "Member", "Admin" instead of "Organization Owner" etc. in the Role column, via a formatRoleTitle helper.
Disable the "Add member" project action when the org has only one member, since there is no one else to search for and add. Also keep the project row highlighted while its action menu is open.
Distinguish an empty tab (no data at all) from a no-match search result: add a dedicated zero state to the members, projects, invoices, tokens and API tabs via the DataTable zeroState prop, so the "no matches for that keyword" copy only appears when a search or filter is active. Table headers are hidden in both states by the DataTable.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 29997903965Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.05%) to 46.674%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions53 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
Use a fixed height instead of min-height so the bar no longer resizes when the New Organization button (taller than the search field) is toggled in and out during search.
Show the three-dot action menu only on row hover, keyboard focus, or while its menu is open, fading the trigger rather than the cell so table row dividers stay intact. Wrap the project and project-member action triggers in IconButton for a pointer cursor and hit area, and widen the project-member popup action column to match the members list.
2 participants
Summary
Changes
Technical Details
Test Plan
SQL Safety (if your PR touches
*_repository.goorgoqu.*)?placeholders,goqu.Ex{}, orgoqu.Record{}— neverfmt.Sprintfor+building a query that gets executed.ToSQL()callers capture and forward params (query, params, err := stmt.ToSQL(); db.…Context(ctx, …, query, params...)). Neverquery, _, err := ….?placeholders inside single-quoted SQL literals ingoqu.L(usemake_interval(hours => ?)-style functions instead).//nolint:forbidigoor// #nosec G20xannotation has a one-line justification on the same line that a reviewer can verify.