[Shreyag02]

Summary

• Upgrade @base-ui/react to ~1.9.0 and @base-ui/utils to ~0.5.0. Base UI 1.9.0 depends on @base-ui/utils 0.5.0.
• Base UI sets the native disabled attribute on Accordion.Trigger and Collapsible.Trigger when they render a button. The tests check toBeDisabled() in place of aria-disabled.
• The onItemHighlighted handlers in Menu and ContextMenu act only on the keyboard reason, so the none reason that typing now reports does not change them.
• Readonly arrays for the Combobox and Select value types are left for a later PR, because feat: [combobox] use base ui chips, clear, empty, and status #954 rewrites the Combobox files.

Behavior changes

• Disabled accordion and collapsible triggers have disabled instead of aria-disabled. Their existing :disabled styles now apply (50% opacity, no pointer events), and the triggers are no longer in the Tab order.
• In menus, activating the trigger of an open submenu closes it, and a submenu closes when focus returns through its focus guard.

Part of #973

• I have followed the pull request section of the contributing guide.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
apsara	Ready	Preview	Oct 29, 2026 10:23am UTC

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 90c33a03-38c6-4d48-8447-d0ddf46cbcb8

Commits

Reviewing files that changed from the base of the PR and between 013e330 and 8b7ef23.

Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing: 3

• packages/react/components/accordion/__tests__/accordion.test.tsx
• packages/react/components/collapsible/__tests__/collapsible.test.tsx
• packages/react/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The React package dependency ranges changed to ~1.9.0 for @base-ui/react and ~0.5.0 for @base-ui/utils. Accordion and collapsible tests now assert that their disabled triggers are natively disabled.

Suggested reviewers: rohanchkrabrty

Priority: Normal

Merge Risk: Minimal · up to 8b7ef

No actionable merge-blocking issue is identified in these dependency and test updates. Merge after normal build and test checks pass.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title names a dependency upgrade to Base UI 1.9.0, which matches the package.json change (@base-ui/react ~1.8.0 to ~1.9.0, with @base-ui/utils ~0.4.0 to ~0.5.0). It is a short, specific single sen…
Description check		The description states the dependency upgrade to @base-ui/react ~1.9.0 and @base-ui/utils ~0.5.0. It also covers the test changes to toBeDisabled() for Accordion and Collapsible triggers, which match …
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names a dependency upgrade to Base UI 1.9.0, which matches the package.json change (@base-ui/react ~1.8.0 to ~1.9.0, with @base-ui/utils ~0.4.0 to ~0.5.0). It is a short, specific single sentence. It does not mention the test changes or the behavior notes, which is acceptable since those are secondary.

Full details: Description check

Explanation

The description states the dependency upgrade to @base-ui/react ~1.9.0 and @base-ui/utils ~0.5.0. It also covers the test changes to toBeDisabled() for Accordion and Collapsible triggers, which match the raw summary. It is related to the changeset in several specific ways.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Biome (2.5.15)

packages/react/components/accordion/__tests__/accordion.test.tsx

Biome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins.

packages/react/components/collapsible/__tests__/collapsible.test.tsx

Biome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins.

packages/react/package.json

Biome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/@raystack/apsara@993

commit: 8b7ef23