Repository navigation
feat: [drawer] add swipe area, keyboard handling, and indent - #956
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
ravisuhag
force-pushed
the
feat/drawer-swipe-area-keyboard-indent
branch
from
October 13, 2026 07:33
ca6425e to
5eede8f
Compare
1 task done
- Add enableVirtualKeyboard to Drawer.Content. The bottom drawer moves up by --drawer-keyboard-inset while the keyboard is open. - Add a container prop to Drawer.Content. - Drawer.Indent renders the indent background. Remove Drawer.IndentBackground. - Give the indent a min-height of 100dvh. - Export DrawerIndentProps and DrawerSwipeAreaProps. - Keep the swipe area and indent docs examples inside their own box.
rohanchkrabrty
approved these changes
Oct 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Drawer.SwipeArea, an invisible edge strip users drag from to open the drawer. It sits on the edge named bysideby default, and acceptsswipeDirectionanddisabled.Wrap
Drawer.Contentin Base UI'sVirtualKeyboardProvider, so focused inputs in a modal drawer stay above the phone keyboard. Apps do not need to set anything up.Add optional
Drawer.Provider,Drawer.Indent, andDrawer.IndentBackgroundfor the iOS-style background inset. Nothing changes unless an app uses them. New slots (drawer-swipe-area,drawer-indent,drawer-indent-background) have tests and docs. Tests cover what jsdom can show. Swipe gestures, the keyboard, and the indent animation still need testing on a real phone.Why it's like this: Sheet moved to Base UI Drawer on Feb 27, 2026 (feat: migrate sheet to drawer #654), two weeks after Base UI first shipped Drawer. SwipeArea and Indent came in Base UI 1.3, and the keyboard provider in 1.6, so the wrapper did not have them.
Breaking: no.
I have followed the pull request section of the contributing guide.