Repository navigation
Conversation
Also guard against empty photo results and drop a duplicate config write.
There was a problem hiding this comment.
🟡 Changes recommended
Login persistence failures now report success, and the download-fallback notification is unreachable.
2 open issues
What changed in this PR
Fixes Windows configuration-path handling for issue #120 and adds terminal status reporting around user interaction.
Changes:
- Resolves configuration paths from the platform-specific home directory and creates
.config. - Adds blocked/resume terminal notifications and helper tests.
- Removes redundant config writes and handles missing photos.
| File | Description |
|---|---|
| main.go | Uses cross-platform home paths and creates the config directory. |
| lib/terminal/status.go | Adds terminal status notifications and message truncation. |
| lib/terminal/status_test.go | Tests truncation and base64 encoding. |
| cmd/root.go | Adds prompt notifications, guards missing photos, and removes a config write. |
| cmd/auth/login.go | Adds authentication notifications and removes a duplicate config write. |
Review effort: Balanced
| logrus.Debug("writing config") | ||
| cobra.CheckErr(viper.WriteConfig()) | ||
|
|
||
| if err := viper.WriteConfig(); err != nil { |
| fmt.Println("") | ||
|
|
||
| var key keyboard.Key | ||
| resume := terminal.Blocked("permission", "Download failed. Set wallpaper from the URL?") |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #120