CI: test Python 3.13 only (ravendb client requires 3.10+)#34
Merged
Conversation
0c19096 to
54e9f27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #33. The post-merge CI on
v7.2failed on theubuntu 3.9job.Root cause
Not our code — the upstream
ravendbclient uses a PEP 604X | Yunion as a runtime value (ravendb/documents/operations/ongoing_tasks.py:422), which only works on Python 3.10+. On 3.9 it raisesTypeError: unsupported operand type(s) for |: 'type' and 'type'at import, so the whole suite fails to load. Python 3.9 cannot work regardless of CI.Change
Test Python 3.13 only, keeping .NET 8 + 10 and both OSes:
ubuntu-latest, 3.13, .NET 10 (forced)ubuntu-latest, 3.13, .NET 8 (default)windows-latest, 3.13, .NET 10 (forced)(The two 3.13 jobs already passed in the failing run;
.NET 8moves onto a 3.13 job, which imports fine.)Note (not changed here)
setup.pystill declarespython_requires=">=3.9", which is effectively inaccurate given the client needs 3.10+. Worth bumping to>=3.10in a future release.