feat: add --debug flag to print full traceback on failure#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The top-level exception handler in
main.pyswallowed the traceback, printing only a one-lineError: .... That's the right default for users, but it made real bugs hard to diagnose.Adds a
--debugflag. On failure:(run with --debug for the full traceback)--debug: the clean line followed by the full tracebackHow
A small
_fail(message, debug)helper centralizes the exit path for both theFileNotFoundErrorand genericExceptionhandlers. It's documented as must-call-from-exceptsotraceback.print_exc()sees the active exception.Tests
CLI parse tests for the flag (default off,
--debugon) plus two_failtests asserting the hint-vs-traceback behavior. Full suite: 375 passed.