feat: add --no-dashboard flag and auto-disable on non-TTY#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main.pyunconditionally constructed and entered the RichLivedashboard, which emits control sequences and repeated frames when stdout is piped, redirected, or running in CI — garbling logs and output.Now:
--dashboard / --no-dashboardflag (default on) lets users opt out explicitly.sys.stdout.isatty()is false, even without the flag. An info line notes when this auto-disable kicks in.run_vector_searchalready accepteddashboard=Noneand guarded every use, so disabling is just passingNone.Tests
Added CLI parse tests for the default-on and
--no-dashboardcases. Full suite: 371 passed.