feat: warn when output extension does not match --format#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
If the
-opath's extension doesn't match the chosen--format, vectrify silently wrote (say) DOT content into a.svgfile. Now it logs a non-fatal warning and proceeds:The check is case-insensitive and also fires when the path has no extension at all. It's a warning, not an error — the file is still written, since the user may have deliberately chosen a name.
How
A small pure helper
format_extension_warning(output_path, fmt, expected_ext) -> str | Nonereturns the message (orNonewhen they match);main()logs it via themainlogger right after selecting the format plugin. The plugin already exposes the canonical extension (.svg/.dot/.typ).Tests
Parametrized match/mismatch cases in
test_main.py, including case-insensitivity and the no-extension case. Full suite: 369 passed.