fix: derive default llm-rate from resolved --workers#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DEFAULT_LLM_RATE = min(2 / DEFAULT_WORKERS, 0.2)was computed once at import time fromos.cpu_count()and baked in as the argparse default, so it ignored the--workersthe user actually chose. The design intent is "keep ~2 LLM calls in flight", but on a 20-core box with--workers 4the rate stayed pinned at0.10(~0.4 concurrent calls, a much slower/cheaper run than intended); the reverse case over-shot.Fix
_default_llm_rate(workers) = min(2/workers, 0.2).--llm-ratenow defaults toNone; after parsing, when the user did not pass it explicitly, it's derived from the resolvedns.workers. An explicit--llm-ratestill wins.DEFAULT_LLM_RATEretained (fromDEFAULT_WORKERS) for--helpdisplay and back-compat.Tests
test_default_llm_rate_tracks_workers(0.2 cap at--workers 4;2/40at--workers 40).test_explicit_llm_rate_overrides_workers_derivation.