Skip to content

ovmerge: Change argument parser from custom parser to argparse - #221

Open
chewi wants to merge 1 commit into
raspberrypi:masterfrom
chewi:ovmerge-argparse
Open

chewi wants to merge 1 commit into
raspberrypi:masterfrom
chewi:ovmerge-argparse

Conversation

@chewi

@chewi chewi commented Oct 24, 2026

Copy link
Copy Markdown

This matches the other scripts and gives nicer help output. It also makes -h exit with status 0 instead of 1, which is useful for distributions to quickly verify that it at least potentially works with a new Python version.

These changes were made with an LLM (sorry, it was mundane and I'm short on time) but verified manually.

@pelwell

pelwell commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

This is not a simple like-for-like reworking - you or your AI have charged the help messages, particularly the explanation of the effect of a lone comma.

@chewi

chewi commented Oct 24, 2026

Copy link
Copy Markdown
Author

I didn't think it was a bad rewording, but okay, I'll keep it word for word.

@pelwell pelwell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much closer to the original. There are some minor differences, mostly improvements or unimportant, but there are two inline comments, that I would like addressed. It would also be good to update the README to match the new format.

Comment thread ovmerge/ovmerge Outdated
Comment thread ovmerge/ovmerge
This matches the other scripts and gives nicer help output. It also
makes -h exit with status 0 instead of 1, which is useful for
distributions to quickly verify that it at least potentially works with
a new Python version.

These changes were made with an LLM but verified manually.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants