Repository navigation
drm/panel: add VIEWE 7 inch JD9365TX in-cell DSI panel #7633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HF-2001
wants to merge
8
commits into
raspberrypi:rpi-6.18.y
Choose a base branch
from
HF-2001:viewe-7inch-jd9365tx
base: rpi-6.18.y
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c34d866
dt-bindings: display: add VIEWE JD9365TX panel binding
HF-2001 b0d3a78
dt-bindings: input: add Jadard JD9365TX touchscreen binding
HF-2001 70fbb48
dt-bindings: backlight: add VIEWE I2C backlight binding
HF-2001 34d6038
drm/panel: add VIEWE JD9365TX 7 inch DSI panel
HF-2001 deda790
Input: add Jadard JD9365TX in-cell touchscreen driver
HF-2001 4ea30fd
backlight: add VIEWE I2C backlight driver
HF-2001 2c24e3b
configs: enable VIEWE 7inch panel drivers
HF-2001 1932bd4
overlays: add vc4-kms-dsi-viewe-7inch
HF-2001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
76 changes: 76 additions & 0 deletions
76
Documentation/devicetree/bindings/display/panel/viewe,jd9365tx.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) | ||
| %YAML 1.2 | ||
| --- | ||
| $id: http://devicetree.org/schemas/display/panel/viewe,jd9365tx.yaml# | ||
| $schema: http://devicetree.org/meta-schemas/core.yaml# | ||
|
|
||
| title: VIEWE 7.0" 720x1280 Jadard JD9365TX MIPI-DSI in-cell panel | ||
|
|
||
| maintainers: | ||
| - Hefei <3066883572@qq.com> | ||
|
|
||
| description: | | ||
| The VIEWE 7KF82 module is a 720x1280 RGB888 video-mode MIPI-DSI panel | ||
| based on Jadard JD9365TX. It uses two DSI data lanes and exposes in-cell | ||
| touch over I2C on the same FPC. | ||
|
|
||
| allOf: | ||
| - $ref: panel-common.yaml# | ||
|
|
||
| properties: | ||
| compatible: | ||
| const: viewe,7kf82 | ||
|
|
||
| reg: | ||
| maxItems: 1 | ||
|
|
||
| vdd-supply: | ||
| description: Panel VDD supply, usually 3.3V | ||
|
|
||
| iovcc-supply: | ||
| description: Panel IO voltage supply, usually 3.3V | ||
|
|
||
| vccio-supply: | ||
| description: Alternate name for iovcc-supply | ||
|
|
||
| reset-gpios: | ||
| description: Optional panel reset GPIO (omit if board uses POR only). | ||
| maxItems: 1 | ||
|
|
||
| backlight: true | ||
| rotation: true | ||
| port: true | ||
|
|
||
| required: | ||
| - compatible | ||
| - reg | ||
| - vdd-supply | ||
|
|
||
| anyOf: | ||
| - required: [iovcc-supply] | ||
| - required: [vccio-supply] | ||
|
|
||
| additionalProperties: false | ||
|
|
||
| examples: | ||
| - | | ||
| dsi { | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| panel@0 { | ||
| compatible = "viewe,7kf82"; | ||
| reg = <0>; | ||
| vdd-supply = <®_vdd>; | ||
| iovcc-supply = <®_iovcc>; | ||
| backlight = <&viewe_bl>; | ||
|
|
||
| port { | ||
| endpoint { | ||
| remote-endpoint = <&dsi_out>; | ||
| data-lanes = <0 1>; | ||
| }; | ||
| }; | ||
| }; | ||
| }; | ||
| ... |
53 changes: 53 additions & 0 deletions
53
Documentation/devicetree/bindings/input/touchscreen/jadard,jd9365tx.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) | ||
| %YAML 1.2 | ||
| --- | ||
| $id: http://devicetree.org/schemas/input/touchscreen/jadard,jd9365tx.yaml# | ||
| $schema: http://devicetree.org/meta-schemas/core.yaml# | ||
|
|
||
| title: Jadard JD9365TX in-cell touchscreen | ||
|
|
||
| maintainers: | ||
| - Hefei <3066883572@qq.com> | ||
|
|
||
| description: | | ||
| In-cell touch integrated with Jadard JD9365TX DSI panels. The module FPC | ||
| often exposes only I2C (no interrupt GPIO); the driver polls coordinate | ||
| reports. | ||
|
|
||
| allOf: | ||
| - $ref: touchscreen.yaml# | ||
|
|
||
| properties: | ||
| compatible: | ||
| const: jadard,jd9365tx | ||
|
|
||
| reg: | ||
| maxItems: 1 | ||
|
|
||
| poll-interval: true | ||
|
|
||
| jadard,coord-addr: | ||
| description: Optional fixed coordinate SRAM address override | ||
| $ref: /schemas/types.yaml#/definitions/uint32 | ||
|
|
||
| required: | ||
| - compatible | ||
| - reg | ||
|
|
||
| unevaluatedProperties: false | ||
|
|
||
| examples: | ||
| - | | ||
| i2c { | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| touchscreen@68 { | ||
| compatible = "jadard,jd9365tx"; | ||
| reg = <0x68>; | ||
| touchscreen-size-x = <720>; | ||
| touchscreen-size-y = <1280>; | ||
| poll-interval = <16>; | ||
| }; | ||
| }; | ||
| ... |
44 changes: 44 additions & 0 deletions
44
Documentation/devicetree/bindings/leds/backlight/viewe,i2c-backlight.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) | ||
| %YAML 1.2 | ||
| --- | ||
| $id: http://devicetree.org/schemas/leds/backlight/viewe,i2c-backlight.yaml# | ||
| $schema: http://devicetree.org/meta-schemas/core.yaml# | ||
|
|
||
| title: VIEWE I2C panel backlight | ||
|
|
||
| maintainers: | ||
| - Hefei <3066883572@qq.com> | ||
|
|
||
| description: | | ||
| Simple I2C backlight used on VIEWE DSI modules. Default protocol is device | ||
| address 0x45, register 0x86, brightness 0..255. | ||
|
|
||
| allOf: | ||
| - $ref: common.yaml# | ||
|
|
||
| properties: | ||
| compatible: | ||
| const: viewe,i2c-backlight | ||
|
|
||
| reg: | ||
| maxItems: 1 | ||
|
|
||
| required: | ||
| - compatible | ||
| - reg | ||
|
|
||
| unevaluatedProperties: false | ||
|
|
||
| examples: | ||
| - | | ||
| i2c { | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| backlight@45 { | ||
| compatible = "viewe,i2c-backlight"; | ||
| reg = <0x45>; | ||
| default-brightness = <200>; | ||
| }; | ||
| }; | ||
| ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
arch/arm/boot/dts/overlays/vc4-kms-dsi-viewe-7inch-overlay.dts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * dtoverlay=vc4-kms-dsi-viewe-7inch | ||
| * VIEWE 7" 720x1280 JD9365TX on DSI1 + i2c_csi_dsi (Pi 3/4/5). | ||
| */ | ||
|
|
||
| /dts-v1/; | ||
| /plugin/; | ||
|
|
||
| / { | ||
| compatible = "brcm,bcm2835"; | ||
|
|
||
| fragment@0 { | ||
| target = <&dsi1>; | ||
| __overlay__ { | ||
| status = "okay"; | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| port { | ||
| dsi_out: endpoint { | ||
| remote-endpoint = <&panel_in>; | ||
| data-lanes = <0 1>; | ||
| }; | ||
| }; | ||
|
|
||
| panel: panel@0 { | ||
| compatible = "viewe,7kf82"; | ||
| reg = <0>; | ||
| status = "okay"; | ||
|
|
||
| vdd-supply = <&vdd_viewe7>; | ||
| iovcc-supply = <&iovcc_viewe7>; | ||
| backlight = <&viewe_bl>; | ||
|
|
||
| port { | ||
| panel_in: endpoint { | ||
| remote-endpoint = <&dsi_out>; | ||
| data-lanes = <0 1>; | ||
| }; | ||
| }; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@1 { | ||
| target-path = "/"; | ||
| __overlay__ { | ||
| vdd_viewe7: regulator-vdd-viewe7 { | ||
| compatible = "regulator-fixed"; | ||
| regulator-name = "vdd-viewe7"; | ||
| regulator-min-microvolt = <3300000>; | ||
| regulator-max-microvolt = <3300000>; | ||
| regulator-always-on; | ||
| }; | ||
|
|
||
| iovcc_viewe7: regulator-iovcc-viewe7 { | ||
| compatible = "regulator-fixed"; | ||
| regulator-name = "iovcc-viewe7"; | ||
| regulator-min-microvolt = <3300000>; | ||
| regulator-max-microvolt = <3300000>; | ||
| regulator-always-on; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@2 { | ||
| target = <&i2c_csi_dsi>; | ||
| __overlay__ { | ||
| status = "okay"; | ||
| clock-frequency = <100000>; | ||
| #address-cells = <1>; | ||
| #size-cells = <0>; | ||
|
|
||
| jadard_tp: touch@68 { | ||
| compatible = "jadard,jd9365tx"; | ||
| reg = <0x68>; | ||
| touchscreen-size-x = <720>; | ||
| touchscreen-size-y = <1280>; | ||
| poll-interval = <16>; | ||
| status = "okay"; | ||
| }; | ||
|
|
||
| viewe_bl: bl@45 { | ||
| compatible = "viewe,i2c-backlight"; | ||
| reg = <0x45>; | ||
| default-brightness = <200>; | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@3 { | ||
| target = <&i2c0if>; | ||
| __overlay__ { | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| fragment@4 { | ||
| target = <&i2c0mux>; | ||
| __overlay__ { | ||
| status = "okay"; | ||
| }; | ||
| }; | ||
|
|
||
| __overrides__ { | ||
| rotation = <&panel>, "rotation:0"; | ||
| notouch = <&jadard_tp>, "status=disabled"; | ||
| nobl = <&viewe_bl>, "status=disabled", <&panel>, "backlight="; | ||
| invx = <&jadard_tp>, "touchscreen-inverted-x?"; | ||
| invy = <&jadard_tp>, "touchscreen-inverted-y?"; | ||
| swapxy = <&jadard_tp>, "touchscreen-swapped-x-y?"; | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason it doesn't work on Pi1, or by implication Compute Modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hardware reason known against Pi 1 / Compute Modules that expose DSI + i2c_csi_dsi — we only listed Pi 3/4/5 because that is what we tested. We asked in the main thread whether you want full MIPI-capable Pi / CM coverage before we update the README wording.