Skip to content

misc: rp1-pio: Add narrowing casts #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelwell merged 1 commit into from
Apr 10, 2026
Merged

misc: rp1-pio: Add narrowing casts #7311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions include/linux/pio_rp1.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#define NUM_PIO_STATE_MACHINES 4
#define PIO_INSTRUCTION_COUNT 32
#define PIO_ORIGIN_ANY ((uint)(~0))
#define PIO_ORIGIN_INVALID ((uint)(~0))
#define GPIOS_MASK ((1 << RP1_PIO_GPIO_COUNT) - 1)

#define PICO_NO_HARDWARE 0
Expand Down Expand Up @@ -280,7 +281,7 @@ static inline bool pio_can_add_program(struct rp1_pio_client *client,

if (bad_params_if(client, program->length > PIO_INSTRUCTION_COUNT))
return false;
args.origin = (program->origin == -1) ? PIO_ORIGIN_ANY : program->origin;
args.origin = (uint16_t)((program->origin == -1) ? PIO_ORIGIN_ANY : program->origin);
args.num_instrs = program->length;

memcpy(args.instrs, program->instructions, args.num_instrs * sizeof(args.instrs[0]));
Expand All @@ -295,7 +296,7 @@ static inline bool pio_can_add_program_at_offset(struct rp1_pio_client *client,
if (bad_params_if(client, program->length > PIO_INSTRUCTION_COUNT ||
offset >= PIO_INSTRUCTION_COUNT))
return false;
args.origin = offset;
args.origin = (uint16_t)offset;
args.num_instrs = program->length;

memcpy(args.instrs, program->instructions, args.num_instrs * sizeof(args.instrs[0]));
Expand All @@ -308,13 +309,13 @@ static inline uint pio_add_program(struct rp1_pio_client *client, const pio_prog
int offset;

if (bad_params_if(client, program->length > PIO_INSTRUCTION_COUNT))
return PIO_ORIGIN_ANY;
args.origin = (program->origin == -1) ? PIO_ORIGIN_ANY : program->origin;
return PIO_ORIGIN_INVALID;
args.origin = (uint16_t)((program->origin == -1) ? PIO_ORIGIN_ANY : program->origin);
args.num_instrs = program->length;

memcpy(args.instrs, program->instructions, args.num_instrs * sizeof(args.instrs[0]));
offset = rp1_pio_add_program(client, &args);
return (offset >= 0) ? offset : PIO_ORIGIN_ANY;
return (offset >= 0) ? offset : PIO_ORIGIN_INVALID;
}

static inline int pio_add_program_at_offset(struct rp1_pio_client *client,
Expand All @@ -325,7 +326,7 @@ static inline int pio_add_program_at_offset(struct rp1_pio_client *client,
if (bad_params_if(client, program->length > PIO_INSTRUCTION_COUNT ||
offset >= PIO_INSTRUCTION_COUNT))
return -EINVAL;
args.origin = offset;
args.origin = (uint16_t)offset;
args.num_instrs = program->length;

memcpy(args.instrs, program->instructions, args.num_instrs * sizeof(args.instrs[0]));
Expand All @@ -337,7 +338,7 @@ static inline int pio_remove_program(struct rp1_pio_client *client, const pio_pr
{
struct rp1_pio_remove_program_args args;

args.origin = loaded_offset;
args.origin = (uint16_t)loaded_offset;
args.num_instrs = program->length;

return rp1_pio_remove_program(client, &args);
Expand Down
Loading