-
Notifications
You must be signed in to change notification settings - Fork 0
Assignment 2 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment 2 #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assignment_1.ipynb file changes should not be in assignment-2 branch.
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the above requested changes and resubmit. Everything else looks good!
|
Sorry Ranveer! I am still seeing changes to assignment_1.ipynb in the branch and the PR. It should only have assignment_2.ipynb changes. To fix this go over https://uoft-dsi-certificates.slack.com/archives/C080M1JFJ8G/p1733888574840979 |
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see https://github.com/ranvikhalar/python/pull/2/files This shows assignment_1.ipynb under the 'Files changed' in the PR. But if you look carefully at the differences, its only in the markdown code "Submission Due Date: 11:59 PM - Dec 2, 2024". I wouldn't worry too much about it.
You took care of the original issue. Well done!
|
Thanks, Anjali |
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist