Skip to content

Conversation

@ranvikhalar
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

@ranvikhalar ranvikhalar closed this Dec 7, 2024
@ranvikhalar ranvikhalar reopened this Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assignment_1.ipynb file changes should not be in assignment-2 branch.

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the above requested changes and resubmit. Everything else looks good!

@anjali-deshpande-hub
Copy link

Sorry Ranveer! I am still seeing changes to assignment_1.ipynb in the branch and the PR. It should only have assignment_2.ipynb changes. To fix this go over https://uoft-dsi-certificates.slack.com/archives/C080M1JFJ8G/p1733888574840979

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see https://github.com/ranvikhalar/python/pull/2/files This shows assignment_1.ipynb under the 'Files changed' in the PR. But if you look carefully at the differences, its only in the markdown code "Submission Due Date: 11:59 PM - Dec 2, 2024". I wouldn't worry too much about it.

You took care of the original issue. Well done!

@ranvikhalar
Copy link
Owner Author

Thanks, Anjali ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants