Repository navigation
chore: use the giouring fork's main (v1.1.2); Go 1.27.3, deps and nixpkgs - #290
Merged
Merged
Conversation
…pkgs - go.mod requires github.com/randomizedcoder/giouring v1.1.2, the fork's main, with no replace. The replace pointed at a local checkout, so a plain `go build ./...` on another machine (and golangci-lint/govet loading the module) failed, and on this one it picked up the old upstream tree with its syscall.munmap linkname. The fork calls mmap/munmap directly, so -ldflags=-checklinkname=0 is gone from the nix checks, the devshell help and the test comments. - nix builds from the same module: nix/lib/patchGoMod.nix and the giouring flake input are removed (nix was pinned to v1.0.1, 9e96b72). - go 1.27.3 in go.mod, and `go get -u ./...`: grpc 1.85.0, x/net 0.62.0, prometheus/common 0.73.1, procfs 0.23.0, cel-go 0.33.2, nats.go 1.55.0, grpc-gateway 2.33.0 and the genproto, pprof and x/exp pseudo-versions. - flake.lock: nixpkgs 2026-10-20 -> 2026-11-05 (Go 1.27.3, iproute2 7.2.0, ethtool 7.1 and golangci-lint 2.15.0 unchanged; linuxPackages_latest 7.3 -> 7.3.1) and microvm.nix 2026-10-09 -> 2026-10-29. - goVendorHash updated; TODO-SOON section 16 marked done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.modnow requiresgithub.com/randomizedcoder/giouring v1.1.2(the fork'smain). The local-pathreplaceis gone, so nix builds the same module.nix/lib/patchGoMod.nixand thegiouringflake input are removed; nix had been stuck at v1.0.1.-checklinkname=0: v1.1.2 calls mmap/munmap as direct syscalls. The workarounds are gone from the nix checks, the devshell help and the test comments.go 1.27.3ingo.mod, plusgo get -u ./...(grpc 1.85.0, x/net 0.62.0, prometheus/common 0.73.1, procfs 0.23.0, cel-go 0.33.2, nats.go 1.55.0, grpc-gateway 2.33.0).goVendorHashis updated.TODO-SOON.md§16 (the giouring linkname item) is marked done.Test plan
test-go-flavor-s3parquet, andtest-linkmonitor's repeated rdma race: 253 s here and 254 s onmain, against a 300 s cap). Both pass when rerun alone.nix build --no-link .#checks.x86_64-linux.test-go-raceOVERALL_PASS,UNGATED_CLEAN,HYGIENE_PASSandDRIVER_PASSvm-*checks on 7.3.1 (not run)🤖 Generated with Claude Code