Repository navigation
Only count freed pages in homa_pool_free_bufs if not upstream - #29
Draft
randomizedcoder wants to merge 1 commit into
Draft
randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
randomizedcoder
added a commit
that referenced
this pull request
Nov 8, 2026
…fork #29) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
freed_pages is read only by a tt_record4, which strip.py removes, so the upstream source fails to compile with W=1: homa_pool.c: error: variable 'freed_pages' set but not used Use __UPSTREAM__ rather than __STRIP__: compile-time stripping keeps the tt_record4, so it still needs the variable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
randomizedcoder
force-pushed
the
fix/pool-freed-pages-strip
branch
from
November 8, 2026 17:48
10832a8 to
fe8909b
Compare
randomizedcoder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
freed_pagesinhoma_pool_free_bufsis read only by att_record4, whichstrip.pyremoves. The stripped file therefore fails to compile in a kernel tree withW=1(gcc, clang and i386):It arrived with the pool rework in f67a4b4. The out-of-tree build and plain
make __STRIP__=1don't useW=1, so they still pass.Fix: put the declaration and the increment inside
#ifndef __UPSTREAM__ /* See strip.py */blocks, sostrip.pyremoves them along with thett_record4. Not__STRIP__: compile-time stripping (make __STRIP__=1) keeps thett_record4, so it still needs the variable. The source compiled in normal and__STRIP__=1builds doesn't change.Checked:
__STRIP__=1.make __STRIP__=1builds the module.HOMA=m,W=1; gcc + sparse, clang, i386) with no warnings.No test, since it's a build fix.
🤖 Generated with Claude Code