Draft
Conversation
- Implement ping router
- implement session bearer to add session id in header
- add TODO for issue found with post and patch requesr #525
6 tasks
2e204de to
5750aa9
Compare
0f4320e to
8ab0d9a
Compare
36f8766 to
74c1979
Compare
a8b597b to
151bc7c
Compare
patrick-austin
requested changes
Mar 13, 2026
patrick-austin
left a comment
There was a problem hiding this comment.
17/85 files down, will keep going on Monday
Base automatically changed from
refactor-dg-api-model-to-pydantic-522
to
develop
March 16, 2026 09:58
patrick-austin
requested changes
Mar 16, 2026
| show_missing = true | ||
|
|
||
| [tool.black] | ||
| line-length = 120 |
There was a problem hiding this comment.
There's a reference to 88 characters per line in the README.md that will need updating because of this.
patrick-austin
requested changes
Mar 16, 2026
patrick-austin
left a comment
There was a problem hiding this comment.
Mostly sting formatting and inconsistent approaches to typehints/docstrings.
This was referenced Mar 16, 2026
f90ec1a to
8b1ddb4
Compare
- only changes in src directory
8b1ddb4 to
32b8294
Compare
- improve formatting in test files
28c9080 to
c4f80a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close #519
Description
Port datagateway-api from flask-restful to fast-api and upgrade the python version to 3.11 (matches scigateway-auth)
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #519
Notes