Reduce flaky integration test failures from timing and PK reuse#758
Open
rafael-pissardo wants to merge 1 commit into
Open
Reduce flaky integration test failures from timing and PK reuse#758rafael-pissardo wants to merge 1 commit into
rafael-pissardo wants to merge 1 commit into
Conversation
Isolation fixes for concurrency/recurring/lifecycle tests that flake on CI: wait for process deregistration and claimed slots, avoid JobResult primary-key reuse from orphaned StoreResultJob writers, scope recurring assertions, and replace fixed sleeps with condition waits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainCI (unrelated to feature PRs).JobResultrows (avoids recycled PK overwrites from orphanedStoreResultJobwriters turningstatusinto"completed"), wait for claimed slots before enqueueing blocked jobs, and adopt the claimed-release wait pattern from Fix flaky concurrency controls test #734.custom_status/value: 42results so leftover rows cannot fail the suite.FailedExecutionrecords in the jobs failure path.Related to #602.
Test plan
bin/rails test test/integration/concurrency_controls_test.rb test/integration/recurring_tasks_test.rb test/integration/jobs_lifecycle_test.rb test/integration/async_processes_lifecycle_test.rbMade with Cursor