Skip to content
This repository was archived by the owner on Apr 12, 2020. It is now read-only.

Massive Update#19

Open
xeoncross wants to merge 4 commits intorafaelhz:masterfrom
xeoncross:master
Open

Massive Update#19
xeoncross wants to merge 4 commits intorafaelhz:masterfrom
xeoncross:master

Conversation

@xeoncross
Copy link
Copy Markdown

@xeoncross xeoncross commented Aug 30, 2017

The current react-material-admin-template repo does not work with the current NPM (and lib) versions. This was a refresh porting all the src components into a brand new create-react-app checkout and then adding axios (ajax) and facebook (login) demos.

Unit tests, linting, etc, are all gone. I broke them all. I couldn't get any of it to work so it was removed. Needs to be fixed and added back in.

This pull request works, adds some new features:

  • It Works
  • React-Router-Dom (v4+)
  • Axios
  • Facebook

Broke/Removed others:

  • Unit Tests
  • Linting
  • Preferences

@jtba
Copy link
Copy Markdown

jtba commented Nov 28, 2017

Would love to see this get merged. Much needed. Could not get the current version to work.

Copy link
Copy Markdown

@MalPr0 MalPr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!. this helped me fix my project.


render(
<Router routes={routes} history={browserHistory} />, document.getElementById('app')
<BrowserRouter>
Copy link
Copy Markdown

@MalPr0 MalPr0 Apr 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move login out app

`

<BrowserRouter>
    <div>
        <Switch>
            <Route exact path="/login" component={LoginPage}/>
            <MuiThemeProvider muiTheme={ThemeDefault}>
                <App />
            </MuiThemeProvider>
        </Switch>
    </div>
</BrowserRouter>

`

@Markkos89
Copy link
Copy Markdown

@rafaelhz would you merge this?

@Markkos89
Copy link
Copy Markdown

@xeoncross how can I use your PR?

@xeoncross
Copy link
Copy Markdown
Author

@Markkos89 just checkout https://github.com/Xeoncross/react-material-admin-template instead of this repo. However, it's been a couple years so there will probably be some additional changes needed. Nice thing is that react-router-dom is still v4.

@rafaelhz
Copy link
Copy Markdown
Owner

Sorry guys, this repo is really outdated, you can clone the @xeoncross version, or use a free theme from material-ui: https://material-ui.com/store/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants