Vmarc q9075 io v1.1 - #589
Open
nascs wants to merge 18 commits into
Open
Conversation
RadxaYuntian
requested changes
Aug 6, 2026
| function = LED_FUNCTION_STATUS; | ||
| gpios = <&pca 0 GPIO_ACTIVE_HIGH>; | ||
| linux,default-trigger = "heartbeat"; | ||
| default-state = "on"; |
Member
There was a problem hiding this comment.
Suggested change
| default-state = "on"; |
这个属性不是你想象中的那个意思，一般也不需要定义
|
|
||
| green_led { | ||
| color = <LED_COLOR_ID_GREEN>; | ||
| function = LED_FUNCTION_STATUS; |
| color = <LED_COLOR_ID_GREEN>; | ||
| function = LED_FUNCTION_STATUS; | ||
| gpios = <&pmm8654au_2_gpios 10 GPIO_ACTIVE_HIGH>; | ||
| default-state = "off"; |
| /* Set default master 0 */ | ||
| s_ctrl->cci_num = CCI_DEVICE_0; | ||
| &s_ctrl->cci_num) < 0) { | ||
| if (of_property_read_u32(of_node, "cci-device", |
Member
There was a problem hiding this comment.
>=0的情况呢？
另外这个if看上去可以和上面那个if的条件合并，另外注释不要删掉
Signed-off-by: William Norman <nascs@radxa.com>
Signed-off-by: William Norman <nascs@radxa.com>
…_regulator Signed-off-by: William Norman <nascs@radxa.com> Co-authored-by: Songjun Li <lisongjun@radxa.com>
Signed-off-by: William Norman <nascs@radxa.com>
…er spi16 Signed-off-by: William Norman <nascs@radxa.com> Co-authored-by: SongJun Li <lisongjun@radxa.com>
Signed-off-by: William Norman <nascs@radxa.com>
Signed-off-by: William Norman <nascs@radxa.com>
nascs
force-pushed
the
vmarc-q9075-io_v1.1
branch
from
August 7, 2026 05:59
66430be to
f6369e3
Compare
Author
|
发现有一个 commit （那个 eeprom 的 commit）之前已经被合并了，所以同步了一下上游 Ubuntu-qcom-6.8.0-1066.67 分支， |
Signed-off-by: William Norman <nascs@radxa.com>
…cci-device Populate qcom,cam-sensor children under qcom,cci nodes as platform devices, and fall back to the sensor node's own "cci-device" property when the parent has no cell-index. Signed-off-by: William Norman <nascs@radxa.com>
Signed-off-by: William Norman <nascs@radxa.com>
Signed-off-by: William Norman <nascs@radxa.com>
Co-authored-by: ZHANG Yuntian <yt@radxa.com>
…_usb_regulator Signed-off-by: William Norman <nascs@radxa.com>
Signed-off-by: William Norman <nascs@radxa.com>
…ulator Signed-off-by: William Norman <nascs@radxa.com>
…tion Signed-off-by: William Norman <nascs@radxa.com>
nascs
force-pushed
the
vmarc-q9075-io_v1.1
branch
from
August 7, 2026 06:17
f6369e3 to
1ecf3dd
Compare
Signed-off-by: William Norman <nascs@radxa.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.