more properties to validator + tests#35
Open
HampuCristian wants to merge 22 commits intofeature/controller-service-repository-cristifrom
Open
more properties to validator + tests#35HampuCristian wants to merge 22 commits intofeature/controller-service-repository-cristifrom
HampuCristian wants to merge 22 commits intofeature/controller-service-repository-cristifrom
Conversation
…to feature/app
toate bune frfr
all actuators + security config
radu103
reviewed
May 15, 2023
| public class CarValidator { | ||
|
|
||
| public static Boolean validateCar(Car car) throws CarValidatorException { | ||
| validateCarMakerOrModel(car.getMaker(), "maker"); |
Owner
There was a problem hiding this comment.
don't do that :) 2 different functions maybe with reuse of code from a common private function
radu103
reviewed
May 15, 2023
|
|
||
| public static void validateCarMakerOrModel(String name, String type) throws CarValidatorException { | ||
| switch(type){ | ||
| case "maker":{ |
Owner
There was a problem hiding this comment.
with the switch you have more lines than having 2 different independent functions. SOLID, S - Single Responsability
Owner
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.