NOMERGE PR.js Build Improvements

.gitignore

@@ -1,2 +1,7 @@
-node_modules/*
-src/jspm_packages/*
+node_modules/
+src/jspm_packages/
+dist/
+
+# TODO: Remove
+build.min.js
+build.min.js.map

.travis.yml

@@ -0,0 +1,13 @@
+language: node_js
+node_js:
+- '0.12'
+before_install:
+- npm install -g jspm
+- jspm config registries.github.auth $RADIFY_JSPM_GITHUB_AUTH_TOKEN
+before_script:
+- npm install
+- jspm install
+script: gulp
+env:
+  global:
+    secure: lPYM9GGMD1qyd4/zhRTGpipOtxHwtQ0EFxgNg9KjRBEMkTLHjeZI0JQNskn0E8ZYXbjYghdUFvXkAAED5F9d0igPRcuLtAau1iGnW2PGyK2rzHE/fpplWFYIdm65CtQP4hv0bEGw3UBx9WkFDqs7NiRTE5YiDh75woP88weI7oxqlfpJdyvMJgoSda87dBYkYVOHCaMGrLkXK3GQhR6eJ20WZIp0TCbiMYLEzpo45BDMZSf9K0yRPiJ9vA3bgWUJGqfW4Dt6k10pKD1Q5SE/WeingOphiBK5Lrfp+Y7i1JkOpPzRC5rDMwJJUbJQpUeAvrmDQCf9VUmrib2iBA5dpRAe4xgOmdNEZaJEjS9lSU+dOtcBHo9mrlJ9pEHSzJO7Q3oLQC8nq7bf/SP1ZlQUnWqtxM3eIUnkIYJTBtzzQkHC3qpa5OZvWHrJIGqj8E1Mafp+1YHhelCHhg+ePiy1sXUvWF+1w3FC8M3O51Q/9YhjetpoqeshjmMdwJaV/8+WMZBieFHLzgLGIySTK6YQUMkUppqmVg524AwTDmMvgfZtr8xN/eBX3SnrUZjW9ILk00qCU/Q6qc/6IczCRyaByBajG2jqePn0wM78F6fGUMVO2Cdpp0P3+uSzKDb8XA8Vp7T1c4JthZ2ljRgP/Lgp4lUD/qEO1qio4a36sd6OVjc=

README.md

@@ -1,3 +1,5 @@
+[![Build Status](https://travis-ci.org/radify/PR.js.svg)](https://travis-ci.org/radify/PR.js)
+
 # PR.js
 
 _Programatically validate pull requests against the [contribution guidelines](https://help.github.com/articles/setting-guidelines-for-repository-contributors/)_
@@ -34,7 +36,7 @@ Most projects have rules of some kind about how to submit pull requests, which o
 
 **Test**
 
- - [`http://localhost:3003/test.html`](http://localhost:3003/test.html)
+ - `gulp test`
 
 ### Roadmap
 

gulp/build.js

@@ -0,0 +1,10 @@
+'use strict';
+
+var gulp   = require('gulp');
+var runSeq = require('run-sequence');
+
+gulp.task('build', function(done) {
+  runSeq('clean', ['buildjs', 'buildcss', 'buildimg'], done);
+});
+
+

gulp/buildcss.js

@@ -0,0 +1,19 @@
+'use strict';
+
+var gulp = require('gulp');
+var autoprefixer = require('gulp-autoprefixer');
+var concat = require('gulp-concat');
+var minifyCss = require('gulp-minify-css');
+var rename = require('gulp-rename');
+
+// Build CSS for distribution.
+gulp.task('buildcss', function () {
+  gulp.src(global.paths.css)
+    .pipe(concat('app.css'))
+    .pipe(autoprefixer())
+    .pipe(minifyCss())
+    .pipe(rename({
+      suffix: '.min'
+    }))
+    .pipe(gulp.dest(global.paths.dist));
+});

gulp/buildimg.js

@@ -0,0 +1,16 @@
+'use strict';
+
+var gulp = require('gulp');
+var imagemin = require('gulp-imagemin');
+var pngquant = require('imagemin-pngquant');
+
+// Build images for distribution.
+gulp.task('buildimg', function () {
+  gulp.src(global.paths.img)
+    .pipe(imagemin({
+      progressive: true,
+      svgoPlugins: [{removeViewBox: false}],
+      use: [pngquant()]
+    }))
+    .pipe(gulp.dest(global.paths.dist + '/img'));
+});

gulp/buildjs.js

@@ -0,0 +1,16 @@
+'use strict';
+
+var gulp = require('gulp');
+var exec   = require('child_process').execSync;
+
+// Build JS for distribution.
+gulp.task('buildjs', function () {
+  exec('npm run buildjs', function (err, stdout, stderr) {
+    if (err) {
+      throw err;
+    }
+    else {
+      console.log('Build complete!');
+    }
+  });
+});

gulp/clean.js

@@ -0,0 +1,9 @@
+'use strict';
+
+var gulp = require('gulp');
+var del = require('del');
+
+// Empty the build dir.
+gulp.task('clean', function (done) {
+  del([global.paths.dist + '/*'], done);
+});

gulp/serve.js

@@ -0,0 +1,15 @@
+'use strict';
+
+var gulp = require('gulp');
+var connect = require('gulp-connect');
+
+// Start local dev server.
+gulp.task('serve', function() {
+  connect.server({
+    root: global.paths.index,
+    port: 3003,
+    livereload: true
+  });
+
+  console.log("Demo server started at localhost:3003");
+});

gulp/test.js

@@ -0,0 +1,10 @@
+'use strict';
+
+require('babel-core/register');
+
+var gulp = require('gulp');
+var jasmine = require('gulp-jasmine');
+
+gulp.task('test', function () {
+  return gulp.src(global.paths.specs).pipe(jasmine({ includeStackTrace: true }));
+});

gulpfile.js

@@ -1,11 +1,38 @@
+'use strict';
+
+/*
+ * gulpfile.js
+ * ===========
+ * Rather than manage one giant configuration file responsible
+ * for creating multiple tasks, each task has been broken out into
+ * its own file in the 'gulp' folder. Any files in that directory get
+ *  automatically required below.
+ *
+ * To add a new task, simply add a new task file in that directory.
+ */
+
 var gulp = require('gulp');
-var conn = require('gulp-connect');
+var requireDir = require('require-dir');
+
+global.paths = {
+  // CSS sources
+  'css': './css/*',
+  // Distribution folder.
+  'dist': './dist',
+  // Image sources.
+  'img': './img/*',
+  // TODO: replace with ./src or ./build
+  'index': './',
+  // Sources folder.
+  'src': './src',
+  // Specs folder.
+  'spec': './spec',
+  // Specs glob.
+  'specs': './spec/**/*Spec.js'
+};
 
-gulp.task('serve', function() {
-  conn.server({
-    root: __dirname,
-    port: 3003
-  });
+// Require all tasks in the 'gulp' folder.
+requireDir('./gulp', { recurse: false });
 
-  console.log("Demo server started at localhost:3003");
-});
+// Default task; test & build
+gulp.task('default', ['test', 'build']);

package.json

@@ -2,8 +2,11 @@
   "name": "pr.js",
   "version": "0.1.1",
   "description": "Simple validation for pull request workflows",
-  "main": "index.js",
-  "scripts": {},
+  "main": "index.html",
+  "scripts": {
+    "buildjs": "jspm bundle-sfx pr.js build.min.js --minify",
+    "test": "gulp test"
+  },
   "author": {
     "name": "Radify, Inc.",
     "email": "line@radify.io",
@@ -34,11 +37,23 @@
   ],
   "dependencies": {},
   "devDependencies": {
+    "babel-core": "^5.8.22",
+    "del": "^1.2.1",
     "gulp": "^3.9.0",
+    "gulp-autoprefixer": "^2.3.1",
     "gulp-babel": "^5.2.1",
     "gulp-concat": "^2.6.0",
     "gulp-connect": "^2.2.0",
-    "gulp-uglify": "^1.2.0"
+    "gulp-imagemin": "^2.3.0",
+    "gulp-jasmine": "^2.0.1",
+    "gulp-minify-css": "^1.2.0",
+    "gulp-rename": "^1.2.2",
+    "gulp-uglify": "^1.2.0",
+    "imagemin-pngquant": "^4.1.2",
+    "jasmine": "^2.3.2",
+    "jspm": "^0.16.1",
+    "require-dir": "^0.3.0",
+    "run-sequence": "^1.1.2"
   },
   "bugs": {
     "url": "https://github.com/radify/PR.js/issues"

spec/parsers/Message.js → spec/parsers/MessageSpec.js

@@ -1,4 +1,4 @@
-import Message from "parsers/Message";
+import Message from "../../src/parsers/Message";
 
 describe("parsers/Message", () => {
   it("should pull the first commit message from a PR, split into lines", () => {

spec/parsers/Subject.js → spec/parsers/SubjectSpec.js

@@ -1,4 +1,4 @@
-import Subject from "parsers/Subject";
+import Subject from "../../src/parsers/Subject";
 
 describe("parsers/Subject", () => {
   it("should split valid subject lines into object hash", () => {

spec/rules/HasSubject.js → spec/rules/HasSubjectSpec.js

@@ -1,4 +1,4 @@
-import HasSubject from "rules/HasSubject";
+import HasSubject from "../../src/rules/HasSubject";
 
 describe("rules/HasSubject", () => {
 

spec/rules/SquashedCommits.js → spec/rules/SquashedCommitsSpec.js

@@ -1,4 +1,4 @@
-import SquashedCommits from "rules/SquashedCommits";
+import SquashedCommits from "../../src/rules/SquashedCommits";
 
 describe("rules/SquashedCommits", () => {
 

spec/rules/SubjectFormat.js → spec/rules/SubjectFormatSpec.js

@@ -1,4 +1,4 @@
-import SubjectFormat from "rules/SubjectFormat";
+import SubjectFormat from "../../src/rules/SubjectFormat";
 
 describe("rules/SubjectFormat", () => {
 

src/config.js

@@ -10,18 +10,16 @@ System.config({
   paths: {
     "github:*": "jspm_packages/github/*",
     "npm:*": "jspm_packages/npm/*",
-    "*Spec": "../spec/*.js",
-    "jasmineBoot": "https://cdnjs.cloudflare.com/ajax/libs/jasmine/2.3.3/boot.js",
-    "jasmineHtml": "https://cdnjs.cloudflare.com/ajax/libs/jasmine/2.3.3/jasmine-html.js",
-    "jasmine": "https://cdnjs.cloudflare.com/ajax/libs/jasmine/2.3.3/jasmine.js"
+    "*Spec": "../spec/*.js"
   },
 
   map: {
     "angular": "npm:angular@1.4.0-rc.2",
     "angular-ui-router": "npm:angular-ui-router@0.2.15",
     "babel": "npm:babel-core@5.8.22",
-    "babel-runtime": "npm:babel-runtime@5.8.20",
-    "core-js": "npm:core-js@1.1.1",
+    "babel-core": "npm:babel-core@5.8.22",
+    "babel-runtime": "npm:babel-runtime@5.2.17",
+    "core-js": "npm:core-js@0.9.8",
     "marked": "npm:marked@0.3.3",
     "ramda": "npm:ramda@0.14.0",
     "github:jspm/nodelibs-process@0.1.1": {
@@ -33,14 +31,9 @@ System.config({
     "npm:angular@1.4.0-rc.2": {
       "process": "github:jspm/nodelibs-process@0.1.1"
     },
-    "npm:babel-runtime@5.8.20": {
+    "npm:core-js@0.9.8": {
       "process": "github:jspm/nodelibs-process@0.1.1"
     },
-    "npm:core-js@1.1.1": {
-      "fs": "github:jspm/nodelibs-fs@0.1.2",
-      "process": "github:jspm/nodelibs-process@0.1.1",
-      "systemjs-json": "github:systemjs/plugin-json@0.1.0"
-    },
     "npm:ramda@0.14.0": {
       "process": "github:jspm/nodelibs-process@0.1.1"
     }