Skip to content

feat(openstack-sync): create subnet pools and their address scopes - #2354

Merged
haseebsyed12 merged 1 commit into
mainfrom
oso-neutronsubnetpoolsyncs
Sep 21, 2026
Merged

haseebsyed12 merged 1 commit into
mainfrom
oso-neutronsubnetpoolsyncs

Conversation

@haseebsyed12

@haseebsyed12 haseebsyed12 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

What does this change do?

  • Each NeutronSubnetPool CR creates one Neutron subnet pool; CIDRs come from Nautobot prefixes referenced by UUID, pool policy (name, address scope, prefix bounds, sharing) lives on the CR.
  • Subnet-pool sync creates the address scope if absent, adopts it if present, and never deletes it (scopes have no ownership marker and outlive any pool).
  • Nautobot stays CIDRs-only; pool policy lives on the CR.

Upgrade impact

  • This change requires operator action to upgrade. If checked, add the
    upgrade-impact label and a release note: run scriv create from the
    repository root and describe the required action in the generated
    changelog.d/ file. See RELEASING.md.

Operator action means anything a deployment has to do beyond a normal resync:
deploy repo or values changes, new or removed secrets, enabling or disabling a
component, or a manual one-time step.

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown

Python test results

129 tests  +53   129 ✅ +53   12s ⏱️ +8s
  1 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 19f47aa. ± Comparison against base commit 1ff4506.

This pull request removes 76 and adds 129 tests. Note that renamed tests count towards both.
ironic_understack.tests.test_device_type ‑ test_device_type_from_directory
ironic_understack.tests.test_device_type ‑ test_device_type_from_yaml
ironic_understack.tests.test_device_type ‑ test_device_type_minimal_yaml
ironic_understack.tests.test_device_type ‑ test_get_resource_class
ironic_understack.tests.test_inspect_hook_chassis_model ‑ test_preserves_other_custom_traits
ironic_understack.tests.test_inspect_hook_chassis_model ‑ test_replaces_stale_chassis_trait
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_empty_system_vendor
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_matching_name_passes
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_mismatched_name_raises
ironic_understack.tests.test_inspect_hook_node_name_check.TestInspectHookNodeNameCheck ‑ test_missing_manufacturer_raises
…
tests.test_backup ‑ test_local_backs_up_mariadb_and_both_ovn_dbs
tests.test_backup ‑ test_local_mariadb_expands_password_inside_pod_not_locally
tests.test_backup ‑ test_local_ovn_uses_ovsdb_container_and_socket_paths
tests.test_backup ‑ test_local_skip_both_is_an_error
tests.test_backup ‑ test_local_surfaces_backup_exec_error
tests.test_backup ‑ test_slug_sanitizes_non_alnum
tests.test_cli ‑ test_bare_invocation_shows_usage_instead_of_missing_command_error
tests.test_cli ‑ test_bare_net_shows_usage_instead_of_missing_command_error
tests.test_cli ‑ test_bare_router_shows_usage_instead_of_missing_command_error
tests.test_cli ‑ test_callback_builds_connection_context
…

♻️ This comment has been updated with latest results.

@haseebsyed12
haseebsyed12 force-pushed the oso-neutronsubnetpoolsyncs branch 11 times, most recently from 21d2eab to 3dc45a7 Compare September 18, 2026 16:10
@haseebsyed12 haseebsyed12 changed the title feat(openstack-sync): Neutron subnet pool sync contract feat(openstack-sync): create subnet pools and their address scopes Sep 18, 2026
@haseebsyed12
haseebsyed12 force-pushed the oso-neutronsubnetpoolsyncs branch from 3dc45a7 to c585e35 Compare September 18, 2026 18:15
@haseebsyed12
haseebsyed12 marked this pull request as ready for review September 18, 2026 18:16
@haseebsyed12
haseebsyed12 requested a review from a team September 18, 2026 18:16
@haseebsyed12
haseebsyed12 force-pushed the oso-neutronsubnetpoolsyncs branch from c585e35 to 19f47aa Compare September 21, 2026 07:13
@geetikabatra

Copy link
Copy Markdown

LGTM

@haseebsyed12
haseebsyed12 added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 9b2e841 Sep 21, 2026
72 checks passed
@haseebsyed12
haseebsyed12 deleted the oso-neutronsubnetpoolsyncs branch September 21, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants