Repository navigation
feat(privacy): add cog for privacy policy - #398
Conversation
Matsukami7
left a comment
There was a problem hiding this comment.
Not blocking, but a few bits of the policy don't match the repo. Some depend on which cogs are loaded:
Worth fixing before it goes live, if these cogs are loaded:
- Sentry: sentry/sentry.py sends the full message content, user ID and display name for every command to Sentry. The policy doesn't mention this, and it undercuts "all persistent data is stored in the bot's own database". If Sentry is SaaS, it needs listing as a third party. If it's self-hosted, it
still needs a mention. - Jail: jail/utils.py saves full channel transcripts as HTML files on disk, and I can't see anything that deletes them. That contradicts "It is not stored outside Discord" and "the only content we keep is content you deliberately save".
- Markov: markov/markov.py builds per-user word chains from the messages of users who opt in. That conflicts with the same "only content we keep" line, and arguably with "we do not build profiles from your messages" and the no-ML claim.
Worth fixing regardless:
4. Data rights: mydata whatdata only returns generic text and a link, not what's held about that person. mydata forgetme only deletes data in cogs that implement it, and in this repo that's just markov and onboarding_role. Red's own prompt also says it won't remove modlog entries, warnings or
mutes. I'd make the moderation team the main route for deletion requests, and say forgetme only covers part of the data.
5. Contact: the only contact route is the Discord server, so banned users can't reach you, and they're the people most likely to have data held on them. I'd add an email address or a form.
Small fixes, can wait:
- Presence: "only" isn't quite right, as report/report.py:259 also uses online/idle status to decide which members to ping for emergency reports. It isn't stored, though.
- Tags: tags/tags.py:74 also logs the user ID and time of each tag use, but the policy only mentions creator/owner.
- LaTeX: latex/latex.py puts the user's expression in a codecogs.com image URL, so it reaches a third party that isn't listed. Last.fm lookups presumably do the same with the linked username, but that cog isn't in this repo so I couldn't check it.
- Access: "access is limited to the bot operators" reads oddly, since mods can also see notes and logged message content.
None of those cogs are active.
Fair points. Re.
They can reach out via r/Homelab modmail, which is suggested in parts of the policy.
Most of these are not applicable given the bot's live config. Many of the cogs in this repo aren't actually in active use. The only one I will address is the following; the remaining points can be assumed irrelevant given how we are currently operating the bot.
This is directly in reference to the bot's infrastructure. Given the surrounding context, I believe this will be clear to human readers. |
Initial Checklist
Details
Does this resolve an issue?
No
Changes
Features / Fixes
Breaking Changes
Additional