[test-generator] Cover analytics reporter guardrails#911
Draft
r3dbars wants to merge 5 commits into
Draft
Conversation
Owner
Author
|
verdict: no-findings-but-human Reviewed head Actions: human signoff because this is a draft PR and touches analytics telemetry bucket coverage. No fix pushed. Checks: reviewed PR metadata, discussion, diff, and status checks; repo-hygiene is passing; read repo/test/Observability guidance; ran manual_merge_handoff: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnalyticsReporter.countBucket,queueDepthBucket,durationBucket, andwordCountBucket, which back bucketed dictation, meeting, onboarding, runtime, and reliability telemetry.AnalyticsReporter.defaultProperties, so missing build metadata and sanitized session IDs stay stable before analytics capture.Missing coverage
Recent analytics work added and expanded bucketed observability payloads, but the shared reporter helpers had gaps in direct fast coverage. Prior commits on this branch covered bucket boundaries. This update stays in the same
AnalyticsReporterseam and covers default metadata behavior that could silently drift into missing app/build fields or unsafe session metadata.Tests added
AnalyticsReporter default properties fall back when build metadata is unavailableAnalyticsReporter default properties trim session identifiersAnalyticsReporter default properties omit blank session identifiersAnalyticsReporter default properties cap long session identifierscountBucket,queueDepthBucket,durationBucket, andwordCountBucket.Verification
bash scripts/dev/agent-preflight.shbash run-tests.sh(3072 passed)bash build.sh --no-openbash build-deps.sh --forcebefore the original build when stale deps were detected.