Skip to content

[test-generator] Cover analytics reporter guardrails#911

Draft
r3dbars wants to merge 5 commits into
mainfrom
codex/test-generator-2026-05-31-count-bucket
Draft

[test-generator] Cover analytics reporter guardrails#911
r3dbars wants to merge 5 commits into
mainfrom
codex/test-generator-2026-05-31-count-bucket

Conversation

@r3dbars
Copy link
Copy Markdown
Owner

@r3dbars r3dbars commented May 31, 2026

Summary

  • Add focused fast coverage for AnalyticsReporter.countBucket, queueDepthBucket, durationBucket, and wordCountBucket, which back bucketed dictation, meeting, onboarding, runtime, and reliability telemetry.
  • Add related guardrail coverage for AnalyticsReporter.defaultProperties, so missing build metadata and sanitized session IDs stay stable before analytics capture.

Missing coverage

Recent analytics work added and expanded bucketed observability payloads, but the shared reporter helpers had gaps in direct fast coverage. Prior commits on this branch covered bucket boundaries. This update stays in the same AnalyticsReporter seam and covers default metadata behavior that could silently drift into missing app/build fields or unsafe session metadata.

Tests added

  • AnalyticsReporter default properties fall back when build metadata is unavailable
  • AnalyticsReporter default properties trim session identifiers
  • AnalyticsReporter default properties omit blank session identifiers
  • AnalyticsReporter default properties cap long session identifiers
  • Existing branch coverage also includes direct boundary and guardrail tests for countBucket, queueDepthBucket, durationBucket, and wordCountBucket.

Verification

  • bash scripts/dev/agent-preflight.sh
  • bash run-tests.sh (3072 passed)
  • bash build.sh --no-open
  • Prior branch verification also ran bash build-deps.sh --force before the original build when stale deps were detected.

@r3dbars
Copy link
Copy Markdown
Owner Author

r3dbars commented May 31, 2026

verdict: no-findings-but-human

Reviewed head 020d409c021ae09a931e71ba3b0d966d72bebb1c. Findings: none.

Actions: human signoff because this is a draft PR and touches analytics telemetry bucket coverage. No fix pushed.

Checks: reviewed PR metadata, discussion, diff, and status checks; repo-hygiene is passing; read repo/test/Observability guidance; ran git diff --check origin/main...origin/codex/test-generator-2026-05-31-count-bucket.

manual_merge_handoff:
head_sha: 020d409
verdict: no-findings-but-human
blockers: draft PR and analytics telemetry human signoff
checks: gh pr view/diff/checks, repo-hygiene passing, local docs reviewed, git diff --check

@r3dbars r3dbars changed the title [test-generator] Cover analytics count buckets [test-generator] Cover analytics buckets May 31, 2026
@r3dbars r3dbars changed the title [test-generator] Cover analytics buckets [test-generator] Cover analytics reporter guardrails May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant