Skip to content

[nightly-review] Fix captured input attenuation diagnostics#907

Merged
r3dbars merged 1 commit into
mainfrom
codex/nightly-review-captured-input-volume-20260530
May 31, 2026
Merged

[nightly-review] Fix captured input attenuation diagnostics#907
r3dbars merged 1 commit into
mainfrom
codex/nightly-review-captured-input-volume-20260530

Conversation

@r3dbars
Copy link
Copy Markdown
Owner

@r3dbars r3dbars commented May 30, 2026

Summary

  • Capture the selected meeting input device scalar at recording start.
  • Make issue Mic audio recording is a lot quiter #500 attenuation classification prefer captured-device volume drops over default-input drops.
  • Guard captured-volume deltas so device recovery cannot compare unrelated input devices.

Nightly Signals Reviewed

Top Risks

  1. Issue Mic audio recording is a lot quiter #500 attenuation instrumentation could misclassify the captured input route; fixed here.
  2. Dictation Bluetooth ready-start timeout still appears in Sentry/PostHog, but latest events line up with the pre/[nightly-review] Force recovery after ready dictation start failures #903 window, so watch next run.
  3. Update check check_timed_out/unknown is noisy in PostHog; not patching tonight because it needs Sparkle/runtime evidence.

Verification

  • bash scripts/dev/agent-preflight.sh
  • git diff --check
  • TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash build-deps.sh --force
  • TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash build.sh --no-open
  • TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash run-tests.sh
  • TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash run-integration-smoke.sh
  • TRANSCRIPTED_DISABLE_FILE_LOGGER=1 swift test
  • /Users/redbars/.codex/skills/codex-review/scripts/codex-review --mode branch

@r3dbars
Copy link
Copy Markdown
Owner Author

r3dbars commented May 30, 2026

verdict: no-findings-but-human

findings: none. The captured-input scalar now owns the attenuation classification when present, default-input facts remain reported separately, and the added tests cover redirected, flat, and unreadable captured-input cases.

actions: no fix pushed.
current_head_sha: 2252702
fix_commit: none
checks: repo-hygiene pass; gh pr view; gh pr diff --patch; gh pr checks; git diff --check origin/main...origin/codex/nightly-review-captured-input-volume-20260530; Meeting/Core/Observability/Test docs reviewed.

manual_merge_handoff:
head_sha: 2252702
verdict: no-findings-but-human
blockers: draft PR; human signoff for meeting audio diagnostics and telemetry surface
checks: repo-hygiene pass; PR metadata/diff/checks reviewed; diff-check clean; Meeting/Core/Observability docs reviewed

@r3dbars r3dbars marked this pull request as ready for review May 31, 2026 01:57
@r3dbars r3dbars merged commit 32ab56a into main May 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant