Skip to content

[test-generator] Cover Claude helper status and config setup flow#905

Merged
r3dbars merged 13 commits into
mainfrom
codex/test-generator-2026-05-29-claude-helper-status
May 31, 2026
Merged

[test-generator] Cover Claude helper status and config setup flow#905
r3dbars merged 13 commits into
mainfrom
codex/test-generator-2026-05-29-claude-helper-status

Conversation

@r3dbars
Copy link
Copy Markdown
Owner

@r3dbars r3dbars commented May 29, 2026

Missing coverage

  • Recent Claude Desktop helper work added status, repair, install, update, and self-test behavior around the bundled Transcripted MCP helper.
  • The installer config snippet had escaping coverage, but the Settings/agent connection guide still had a separate hand-built Claude MCP JSON example.
  • That agent-facing setup text could drift from the installer formatter and produce invalid JSON for unusual but legal helper paths.
  • The actual Claude Desktop config writer only had simple command-path coverage, leaving the install/repair write path under-tested for escaped helper paths.
  • The new attentionMessage repair policy had scenario coverage through filesystem status tests, but mixed-state precedence was not directly locked down.
  • The guide's Claude config tests verified parseability, but did not lock the guide output to the installer formatter byte-for-byte.

Tests added

  • Covered installed/helper-ready Claude Desktop status, stale or missing helper repair states, malformed config shapes, install/self-test paths, and helper health output.
  • Covered config snippet escaping for spaces, quotes, backslashes, and newlines.
  • Added AgentConnectionGuide coverage for the Settings Claude config example: parseable default config, server-name guardrail, spaces, quotes/backslashes, and newline command paths.
  • Added Claude config writer coverage for command paths with spaces, quotes/backslashes, newlines, and stale Transcripted command repair while preserving unrelated MCP servers.
  • Added direct attentionMessage precedence coverage for installed, fresh setup, missing bundled helper, and unreadable-config-before-stale-helper states.
  • Added AgentConnectionGuide formatter-alignment coverage so the default, spaced, escaped, and newline helper-path examples stay tied to ClaudeDesktopIntegrationInstaller.configSnippet.

Implementation note

  • ClaudeDesktopIntegrationInstaller.configSnippet now uses JSONSerialization instead of manual string interpolation.
  • ClaudeDesktopIntegrationInstaller.runSelfTest now rejects decoded helper output when ok=false, while keeping user-facing copy generic.
  • AgentConnectionGuide.mcpConfigExample now reuses the installer snippet formatter so the agent-facing setup text cannot drift.

Checks run

  • bash scripts/dev/agent-preflight.sh
  • git diff --check
  • bash build.sh --no-open
  • bash run-tests.sh (3012 passed)

@r3dbars r3dbars changed the title [test-generator] Cover Claude helper status warnings [test-generator] Cover Claude helper status and install flow May 30, 2026
@r3dbars
Copy link
Copy Markdown
Owner Author

r3dbars commented May 30, 2026

verdict: no-findings-but-human

findings: none. The moved head adds Claude config command-path escaping coverage for spaces, quotes, backslashes, and newlines; the shared JSON formatter/write path still preserves unrelated MCP servers and keeps self-test failure copy generic.

actions: no fix pushed.
current_head_sha: 98d2c61
fix_commit: none
checks: repo-hygiene pass; gh pr view; gh pr diff --patch; gh pr checks; git diff --check origin/main...origin/codex/test-generator-2026-05-29-claude-helper-status; scripts/dev/agent-preflight.sh; TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash build-deps.sh --force; TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash build.sh --no-open; TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash run-tests.sh (3004 passed); Support/UI/Test docs reviewed.

manual_merge_handoff:
head_sha: 98d2c61
verdict: no-findings-but-human
blockers: draft PR; human signoff for Claude Desktop helper install/config/self-test behavior
checks: repo-hygiene pass; PR metadata/diff/checks reviewed; diff-check clean; preflight/build-deps/build/fast-tests passed; Support/UI/Test docs reviewed

@r3dbars r3dbars changed the title [test-generator] Cover Claude helper status and install flow [test-generator] Cover Claude helper status, install, and update flow May 30, 2026
@r3dbars r3dbars changed the title [test-generator] Cover Claude helper status, install, and update flow [test-generator] Cover Claude helper status, install, update, and self-test flow May 30, 2026
@r3dbars r3dbars changed the title [test-generator] Cover Claude helper status, install, update, and self-test flow [test-generator] Cover Claude helper status and config setup flow May 30, 2026
@r3dbars r3dbars marked this pull request as ready for review May 31, 2026 01:57
@r3dbars r3dbars merged commit f8d6004 into main May 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant