Skip to content

[bug-hunter] Fix saved-before-quit recovery classification#823

Merged
r3dbars merged 1 commit into
mainfrom
codex/bug-hunter-saved-before-quit-classifier
May 20, 2026
Merged

[bug-hunter] Fix saved-before-quit recovery classification#823
r3dbars merged 1 commit into
mainfrom
codex/bug-hunter-saved-before-quit-classifier

Conversation

@r3dbars
Copy link
Copy Markdown
Owner

@r3dbars r3dbars commented May 20, 2026

Summary

  • fixes .savedBeforeQuit meeting failures so retained audio is classified as recoverable instead of permanent when the failed row is not marked directly retryable
  • adds a regression test for the finish-later path from Home

Signal

Recent PR #815 added active-meeting quit safety and a savedBeforeQuit failure kind. Review feedback on that PR flagged that MeetingFailureExplanation added the kind to save-stage reporting, but not to the sibling retryability/outcome switches.

Root Cause

MeetingFailureExplanation listed save-stage recovery kinds in multiple switches, and .savedBeforeQuit was missing from resolvedRetryability and resolvedOutcomeKind.

Verification

  • bash build-deps.sh --force (needed because local deps were stale)
  • bash build.sh
  • TRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash run-tests.sh
  • bash run-integration-smoke.sh

@r3dbars
Copy link
Copy Markdown
Owner Author

r3dbars commented May 20, 2026

verdict: no-findings-but-human

findings: none from this pass.
actions: human signoff recommended because this is a draft meeting-recovery behavior fix, even though the classifier/test change looks focused.
head_sha: f1139cb
fix_commit: none
checks: gh pr view, gh pr diff, Meeting/Test docs read, git diff --check origin/main...origin/codex/bug-hunter-saved-before-quit-classifier, fast-test manifest registration checked, static review of MeetingFailureExplanation saved-before-quit retry/outcome wiring; GitHub checks reported none.

manual_merge_handoff:
head_sha: f1139cb
verdict: no-findings-but-human
blockers: draft PR plus meeting recovery behavior needs human signoff
checks: gh metadata/diff, local docs/static review, diff check, manifest check

@r3dbars r3dbars marked this pull request as ready for review May 20, 2026 16:46
@r3dbars r3dbars merged commit 21eee51 into main May 20, 2026
@r3dbars r3dbars deleted the codex/bug-hunter-saved-before-quit-classifier branch May 20, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant