You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fixes .savedBeforeQuit meeting failures so retained audio is classified as recoverable instead of permanent when the failed row is not marked directly retryable
adds a regression test for the finish-later path from Home
Signal
Recent PR #815 added active-meeting quit safety and a savedBeforeQuit failure kind. Review feedback on that PR flagged that MeetingFailureExplanation added the kind to save-stage reporting, but not to the sibling retryability/outcome switches.
Root Cause
MeetingFailureExplanation listed save-stage recovery kinds in multiple switches, and .savedBeforeQuit was missing from resolvedRetryability and resolvedOutcomeKind.
Verification
bash build-deps.sh --force (needed because local deps were stale)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.savedBeforeQuitmeeting failures so retained audio is classified as recoverable instead of permanent when the failed row is not marked directly retryableSignal
Recent PR #815 added active-meeting quit safety and a
savedBeforeQuitfailure kind. Review feedback on that PR flagged thatMeetingFailureExplanationadded the kind to save-stage reporting, but not to the sibling retryability/outcome switches.Root Cause
MeetingFailureExplanationlisted save-stage recovery kinds in multiple switches, and.savedBeforeQuitwas missing fromresolvedRetryabilityandresolvedOutcomeKind.Verification
bash build-deps.sh --force(needed because local deps were stale)bash build.shTRANSCRIPTED_DISABLE_FILE_LOGGER=1 bash run-tests.shbash run-integration-smoke.sh