feat: add id-length lint rule and refactor related code - #102
Open
hmd-ali wants to merge 1 commit into
Open
Conversation
wiktoriavh
requested changes
Aug 24, 2026
| 'prefer-template': 'warn', | ||
| 'typescript/no-explicit-any': 'error', | ||
| 'prefer-const': 'error', | ||
| 'id-length': [ |
Member
There was a problem hiding this comment.
rename to "disallow-abbreviation".
Suggested change
| 'id-length': [ | |
| 'disallow-abbreviation': [ |
Contributor
Author
There was a problem hiding this comment.
It's the rule id-length
I'm not sure what you mean by rename it? unless you want to use different rule?
| @@ -1,3 +1,4 @@ | |||
| // oxlint-disable id-length | |||
Member
There was a problem hiding this comment.
Suggested change
| // oxlint-disable id-length | |
| // oxlint-disable disallow-abbreviation |
Comment on lines
+16
to
+21
| { | ||
| min: 2, | ||
| checkGeneric: false, | ||
| exceptions: ['_', 'i', 'j', 'x', 'y', 'z'], | ||
| }, | ||
| ], |
Member
There was a problem hiding this comment.
Can you add an error message saying: Use full, descriptive words instead of abbreviations.
Contributor
Author
There was a problem hiding this comment.
I'm not sure about this either? Can we have custom lint messages?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬