Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- Round 950-999 uncertainties up to the next power of ten explicitly, since round() rounded e.g. 0.95 down to 0.9 - Share the highest-order-digit extraction via pdg_hod() and round once - Add tests for the boundary, other magnitudes and both notations - Add NEWS entry under a new devel header Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks @davidchall for spinning this! I reviewed it with our French Friend and found some issues, they were simple enough, so I committed them directly:
@davidchall @alusiani Could you please try this? |
Cover the 100/354/355/949/950/999 edges, 0.9996 rolling over to the next power of ten, the rounded (not truncated) three highest digits, zero/negative values and zero/NA/Inf errors with digits="pdg". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
...
I tested the patched errors package, I found it 100% compliant with PDG prescriptions. You can go ahead, this is an improvement of the released code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Particle Data Group rounding treats uncertainties whose leading three digits fall in the 950-999 range as a special case: they round up to 1000 and keep two significant digits. The previous logic treated those values like the 355-949 case, which produced a one-digit uncertainty instead of the expected two-digit result.
What changed
Fixes #65