Skip to content

Initialize metrics when tokio-console is enabled #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mallets merged 2 commits into from
May 20, 2026
Merged

Initialize metrics when tokio-console is enabled #6448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8596848
Initialize metrics with tokio-console
shuheiktgw May 19, 2026
579a346
Merge branch 'main' into fix-tokio-console-metrics
Mallets May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion quickwit/quickwit-cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,11 @@ fn init_telemetry(
#[cfg(feature = "tokio-console")]
{
if quickwit_common::get_bool_from_env(QW_ENABLE_TOKIO_CONSOLE_ENV_KEY, false) {
let telemetry_handle =
quickwit_telemetry_exporters::init_meter_provider_only(service_version)?;
console_subscriber::init();
return Ok((
quickwit_telemetry_exporters::TelemetryHandle::default(),
telemetry_handle,
quickwit_telemetry_exporters::do_nothing_env_filter_reload_fn(),
));
}
Expand Down
15 changes: 14 additions & 1 deletion quickwit/quickwit-telemetry-exporters/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ pub fn do_nothing_env_filter_reload_fn() -> EnvFilterReloadFn {
Arc::new(|_| Ok(()))
}

#[derive(Default)]
pub struct TelemetryHandle {
tracer_provider: Option<SdkTracerProvider>,
logger_provider: Option<SdkLoggerProvider>,
Expand Down Expand Up @@ -170,3 +169,17 @@ pub fn init_telemetry(

Ok(telemetry_handle)
}

/// Initializes only metrics providers for the process.
///
/// This is useful when another component owns the tracing subscriber setup but
/// Quickwit still needs to install its metrics recorder.
pub fn init_meter_provider_only(service_version: &str) -> anyhow::Result<TelemetryHandle> {
let otlp_config = otlp::OtlpExporterConfig::load_from_env();
let meter_provider = metrics::init_metrics_provider(service_version, &otlp_config)?;
Ok(TelemetryHandle {
tracer_provider: None,
logger_provider: None,
meter_provider,
})
}
Loading