Skip to content

Add distributed tracing to gRPC stack#6403

Draft
guilload wants to merge 2 commits into
mainfrom
guilload/grpc-tracing
Draft

Add distributed tracing to gRPC stack#6403
guilload wants to merge 2 commits into
mainfrom
guilload/grpc-tracing

Conversation

@guilload
Copy link
Copy Markdown
Member

@guilload guilload commented May 7, 2026

Description

  • Add spans to generated gRPC clients/servers via codegen
  • Propgate context RPCs
  • Add additional spans to ingester/mrecordlog to figure out cause of long lock holds

How was this PR tested?

  • Tested locally with Jaeger

@guilload guilload force-pushed the guilload/grpc-tracing branch 3 times, most recently from 7b33bdd to d24bcd9 Compare May 11, 2026 17:57
@guilload guilload force-pushed the guilload/grpc-tracing branch 2 times, most recently from ecfa3eb to 7d6072c Compare May 12, 2026 18:35
Comment thread quickwit/quickwit-common/src/lib.rs Outdated
pub mod test_utils;
pub mod thread_pool;
pub mod tower;
pub mod tracing;
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename tracing_utils

Comment thread quickwit/quickwit-common/src/tracing.rs Outdated
/// Installs a `TraceContextPropagator` once for the whole test binary.
/// `set_text_map_propagator` is process-global; calling it from each
/// test would race, so we gate it behind `Once`.
fn install_propagator() {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find a way to unit test without installing a global propagator.

}

async fn run_operation<F, T>(&mut self, operation: F) -> T
/// Runs `operation` on a blocking task, instrumenting it with `inner_span`
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorten this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant