network: add NMSettings and NMConnectionContext by cpwrs · Pull Request #535 · quickshell-mirror/quickshell

cpwrs · 2026-02-02T05:46:40Z

This exposes the connection settings from NetworkManager. It also exposes a creatable NMConnectionContext object that emits signals about connection attempts and tracks their respective connection settings.

Additions:

NMConnectionContext
- Emits all the signals I could find that would be relevant to a wifi connections lifecycle
- Keeps a reference to the settings relevant to the signals emitted
NMSettings class accessible via Network.nmSettings.
NMDevice.nmStateReason
Network.connectWithSettings() for the multi-setting network use case
Reference types where possible in doc comments

Fixes:

Unmanaged devices are now included in the model, and NetworkDevice.managed is a writable prop
Moved WifiNetwork.{connect, disconnect, forget}() to its parent class Network
securityFromConnectionSettings correctly handles Unknown, Open, and Owe

…tion

outfoxxed · 2026-02-04T13:04:13Z

noticing you formatted it, is this ready now?

cpwrs · 2026-02-04T17:49:43Z

noticing you formatted it, is this ready now?

Not yet, gotta add back some password stuff. I have time to work on it today

src/network/test/manual/network.qml

cpwrs · 2026-02-17T05:54:59Z

src/network/network.cpp

+void NMConnectionContext::setNetwork(Network* network) {
+	if (this->bNetwork == network) return;
+	if (this->bNetwork) disconnect(this->bNetwork, nullptr, this, nullptr);
+	this->bNetwork = network;
+	if (!network) return;
+
+	QObject::connect(network, &Network::activeSettingsChanged, this, [network, this]() {
+		if (network->activeSettings()) {
+			if (this->bSettings) disconnect(this->bSettings, nullptr, this, nullptr);
+			this->bSettings = network->activeSettings();
+			QObject::connect(this->bSettings, &NMSettings::destroyed, this, [this]() {
+				this->bSettings = nullptr;
+			});
+		};
+	});
+	QObject::connect(network, &Network::stateChanged, this, [network, this]() {
+		if (network->state() == NetworkState::Connected) emit this->activated();
+		if (network->state() == NetworkState::Connecting) emit this->activating();
+	});
+	QObject::connect(network, &Network::nmStateReasonChanged, this, [network, this]() {
+		// "Device disconnected" isn't useful, so we defer to the last device fail reason.
+		if (network->nmStateReason() == NMNetworkStateReason::DeviceDisconnected) {
+			auto failReason = network->nmDeviceFailReason();
+			if (failReason == NMDeviceStateReason::NoSecrets) emit this->noSecrets();
+			if (failReason == NMDeviceStateReason::SupplicantDisconnect)
+				emit this->supplicantDisconnect();
+			if (failReason == NMDeviceStateReason::SupplicantFailed) emit this->supplicantFailed();
+			if (failReason == NMDeviceStateReason::SupplicantTimeout) emit this->supplicantTimeout();
+		};
+	});
+
+	connect(network, &Network::destroyed, this, [this]() { this->bNetwork = nullptr; });
+}


I included a really basic set, but it could include signals for anything from
https://networkmanager.dev/docs/api/latest/nm-dbus-types.html#NMDeviceStateReason
or
https://networkmanager.dev/docs/api/latest/nm-dbus-types.html#NMActiveConnectionStateReason

The latter unfortunately only emits for VPN connections, for wifi conns its always DeviceDisconnected.

Sadly there's no "auth failed", that falls under NoSecrets

cpwrs · 2026-02-17T05:56:07Z

src/network/network.hpp

+	/// A network to provide connection context for or `null`.
+	Q_PROPERTY(Network* network READ network WRITE setNetwork NOTIFY networkChanged)
+	/// The last connection settings that context signals were emitted for or `null`.
+	Q_PROPERTY(NMSettings* settings READ default NOTIFY settingsChanged BINDABLE bindableSettings)


Is this what you were thinking for a "callback" to the specific settings?

cpwrs · 2026-02-17T06:19:11Z

I couldn't find a useful way to expose the settings as a big QMap (or multiple smaller maps), so it's empty besides the psk setter. Adding invokables for the popular eap methods is easy enough but I wasn't able to test them.

As far as connection context, I was disappointed to learn that only VPN connections hit the more descriptive state reasons in https://networkmanager.dev/docs/api/latest/nm-dbus-types.html#NMActiveConnectionStateReason.
I was also not sure how the context should be implemented in QML. Let me know how I can clean this up!

outfoxxed · 2026-03-03T09:39:45Z

Just checking in on this because it'd be nice to have in 0.3 which I want to cut this month. I should be around to review on more sane timelines than usual.

cpwrs · 2026-03-19T01:07:59Z

src/network/nm/dbus_types.hpp

+struct NMIPv6Address {
+	QByteArray address;
+	quint32 prefix = 0;
+	QByteArray gateway;
+};
+
+const QDBusArgument& operator>>(const QDBusArgument& argument, qs::network::NMIPv6Address& addr);
+const QDBusArgument& operator<<(QDBusArgument& argument, const qs::network::NMIPv6Address& addr);
+
+const QDBusArgument&
+operator>>(const QDBusArgument& argument, QList<qs::network::NMIPv6Address>& list);
+const QDBusArgument&
+operator<<(QDBusArgument& argument, const QList<qs::network::NMIPv6Address>& list);
+
+struct NMIPv6Route {
+	QByteArray destination;
+	quint32 prefix = 0;
+	QByteArray nexthop;
+	quint32 metric = 0;
+};
+
+const QDBusArgument& operator>>(const QDBusArgument& argument, qs::network::NMIPv6Route& route);
+const QDBusArgument& operator<<(QDBusArgument& argument, const qs::network::NMIPv6Route& route);
+
+const QDBusArgument&
+operator>>(const QDBusArgument& argument, QList<qs::network::NMIPv6Route>& list);
+const QDBusArgument&
+operator<<(QDBusArgument& argument, const QList<qs::network::NMIPv6Route>& list);


These struct settings are deprecated on stable but are still initialized by NM by default

cpwrs · 2026-03-19T01:18:30Z

src/network/nm/settings.hpp

+	/// Update the connection with new settings and save the connection to disk.
+	/// Only changed fields need to be included.
+	///
+	/// > [!NOTE] Secrets may be part of the update request,
+	/// > and will be either stored in persistent storage or sent to a Secret Agent for storage,
+	/// > depending on the flags associated with each secret.
+	Q_INVOKABLE void write(const QVariantMap& settings);
+	/// Get the settings map describing this network configuration.
+	///
+	/// > [!NOTE] This will never include any secrets required for connection to the network, as those are often protected.
+	Q_INVOKABLE QVariantMap read();


This can just be a Q_PROPERTY now if that's preferred. I can throw in read only props for id/uuid too for convenience.

write() is nice because you only have to give it the fields you want changed. Right now this provides setting = null to remove/unset a setting.

cpwrs · 2026-03-20T18:15:58Z

src/network/nm/dbus_types.hpp

+const QDBusArgument& operator>>(const QDBusArgument& argument, QList<QVariantMap>& list);
+const QDBusArgument& operator<<(QDBusArgument& argument, const QList<QVariantMap>& list);
+const QDBusArgument& operator>>(const QDBusArgument& argument, QList<quint32>& list);
+const QDBusArgument& operator<<(QDBusArgument& argument, const QList<quint32>& list);
+const QDBusArgument& operator>>(const QDBusArgument& argument, QList<QList<quint32>>& list);
+const QDBusArgument& operator<<(QDBusArgument& argument, const QList<QList<quint32>>& list);
+const QDBusArgument& operator>>(const QDBusArgument& argument, QList<QByteArray>& list);
+const QDBusArgument& operator<<(QDBusArgument& argument, const QList<QByteArray>& list);


Didn't type alias these because more than one setting uses these signatures and this would be the correct operator for them in any context.

I can give them some general aliases and bring them into network scope if you prefer

network: NMConnection, Network.nmConnections, Network.nmDefaultConnec…

77537fc

…tion

cpwrs force-pushed the nm-connection branch from 179562f to 77537fc Compare February 4, 2026 04:49

network: add NMConnectionContext

9e9b216

cpwrs force-pushed the nm-connection branch 2 times, most recently from e90eae3 to db97686 Compare February 10, 2026 05:17

network: NMConnection.setWifiPsk

b517401

cpwrs force-pushed the nm-connection branch from db97686 to b517401 Compare February 11, 2026 23:13

network: add NetworkDevice.nmStateReason

799f4eb

cpwrs force-pushed the nm-connection branch 2 times, most recently from dda9fcc to d982e7f Compare February 17, 2026 05:41

cpwrs changed the title ~~network: add NMConnection and NMConnectionContext~~ network: add NMSettings and NMConnectionContext Feb 17, 2026

cpwrs commented Feb 17, 2026

View reviewed changes

src/network/test/manual/network.qml Show resolved Hide resolved

cpwrs commented Feb 17, 2026

View reviewed changes

cpwrs marked this pull request as ready for review February 17, 2026 06:05

cpwrs force-pushed the nm-connection branch 2 times, most recently from 23cf03a to 8717373 Compare February 23, 2026 03:26

cpwrs marked this pull request as draft February 23, 2026 22:26

network: add WiFi signals to connection context

59ac606

cpwrs force-pushed the nm-connection branch 5 times, most recently from 3fe56a4 to e20267d Compare February 27, 2026 21:35

network: merge backend/frontend NM settings

e80c30f

cpwrs force-pushed the nm-connection branch from e20267d to e80c30f Compare February 28, 2026 01:01

outfoxxed force-pushed the master branch 5 times, most recently from ca90821 to 3cf65af Compare March 17, 2026 17:10

cpwrs commented Mar 19, 2026

View reviewed changes

cpwrs force-pushed the nm-connection branch from aae9708 to e100037 Compare March 19, 2026 23:48

cpwrs marked this pull request as ready for review March 19, 2026 23:59

cpwrs commented Mar 20, 2026

View reviewed changes

network: settings is just map

df8d19f

cpwrs force-pushed the nm-connection branch from e100037 to df8d19f Compare March 20, 2026 19:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

network: add NMSettings and NMConnectionContext#535

network: add NMSettings and NMConnectionContext#535
cpwrs wants to merge 7 commits intoquickshell-mirror:masterfrom
cpwrs:nm-connection

cpwrs commented Feb 2, 2026 •

edited

Loading

Uh oh!

outfoxxed commented Feb 4, 2026

Uh oh!

cpwrs commented Feb 4, 2026

Uh oh!

Uh oh!

cpwrs Feb 17, 2026

Uh oh!

cpwrs Feb 17, 2026

Uh oh!

cpwrs commented Feb 17, 2026

Uh oh!

outfoxxed commented Mar 3, 2026 •

edited

Loading

Uh oh!

cpwrs Mar 19, 2026 •

edited

Loading

Uh oh!

cpwrs Mar 19, 2026 •

edited

Loading

Uh oh!

cpwrs Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cpwrs commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

outfoxxed commented Feb 4, 2026

Uh oh!

cpwrs commented Feb 4, 2026

Uh oh!

Uh oh!

cpwrs Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

cpwrs Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

cpwrs commented Feb 17, 2026

Uh oh!

outfoxxed commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cpwrs Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cpwrs Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cpwrs Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cpwrs commented Feb 2, 2026 •

edited

Loading

outfoxxed commented Mar 3, 2026 •

edited

Loading

cpwrs Mar 19, 2026 •

edited

Loading

cpwrs Mar 19, 2026 •

edited

Loading