Repository navigation
build: bump p-queue from 9.3.3 to 10.0.0 - #1214
Merged
Merged
Conversation
Bumps [p-queue](https://github.com/sindresorhus/p-queue) from 9.3.3 to 10.0.0. - [Release notes](https://github.com/sindresorhus/p-queue/releases) - [Commits](sindresorhus/p-queue@v9.3.3...v10.0.0) --- updated-dependencies: - dependency-name: p-queue dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
juliasilge
approved these changes
Oct 28, 2026
juliasilge
left a comment
Collaborator
There was a problem hiding this comment.
I tested this bump manually in a Positron desktop dev build. All checks passed.
The extension uses p-queue in one place only, ExecuteQueue in apps/vscode/src/host/execute-queue.ts. This code makes one queue for each language, with concurrency: 1, and calls add(). The changes in p-queue 10 (it extends EventTarget, it removes p-timeout, and it needs Node 22 or later) do not change these calls. Positron and VS Code 1.101 or later run the extension host on Node 22. tsc --noEmit also passes.
What I tested:
- The extension activates and the Extension Host output shows no errors.
- When I click Run Cell on many cells quickly, the cells run one at a time, in the order of the clicks.
- Run Above, Run Below, and Run All run the cells in order.
- When a cell has an error, Run All stops at that cell and no notification popup shows.
- After the error, the queue does not stop. The next cell runs immediately.
- R and Python have separate queues. A slow R cell does not block a Python cell.
The web build does not need a separate test. The browser entry is a stub, and Positron Server runs out/main.js in a Node extension host, the same as desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps p-queue from 9.3.3 to 10.0.0.
Release notes
Sourced from p-queue's releases.
... (truncated)
Commits
7f272ab10.0.00ad6186Tweakscb25a0aFix.onEmpty()waiting for the task to finish when the task starts at once95622a4Fix tasks that share a signal taking O(n²) time to add, run, and abort450356aFix an.add()or an abort at the end of a window starting only one waiting ...a5b7b54Fix a waiting task running in the async context of the code that started itfa3c3e0Fix the types of.addEventListener()and.removeEventListener()rejecting...d6cf96bFix constructor options that areundefinedthrowing instead of using their ...6fb8337FixPriorityQueuekeeping the functions of tasks that already ran48586f4Fix setting an invalid.timeouton the queue making every later.add()re...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)