Repository navigation
Prevent hover hangs outside single-line display math - #1212
Open
moritzketzer wants to merge 1 commit into
Open
moritzketzer wants to merge 1 commit into
moritzketzer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hovering over
afterin a.qmdfile containingBefore $$x$$ afterhangs the language server.The single-line display-math regex is missing the
gflag, soinlineMathRange()keeps finding the same match when the cursor is outside it. Adding the flag lets the scan advance and terminate.Includes regression tests for positions before, between and after expressions, plus repeated lookups. The tests use a timeout so this regression cannot hang the test suite.
Reproduced with the language servers bundled in Quarto VS Code 1.138.0 and 1.139.0 on macOS arm64. Core and LSP tests, core lint, and the LSP build pass.