Skip to content

fix: keep the visual editor's insert symbol popup open across decoration-only transactions (release/rstudio-montauk-daisy) #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinushey wants to merge 1 commit into from
Closed

fix: keep the visual editor's insert symbol popup open across decoration-only transactions (release/rstudio-montauk-daisy) #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/editor/src/behaviors/insert_symbol/insert_symbol-plugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,14 @@ export class InsertSymbolPlugin extends Plugin<boolean> {
super({
key: pluginKey,
view: () => ({
update: () => {
this.closePopup();
update: (view: EditorView, prevState: EditorState) => {
// The realtime spelling plugin dispatches decoration-only
// transactions on a timer (100ms and 5s after the editor is first
// focused), so only treat a change to the document or selection as
// a reason to dismiss the popup.
if (!view.state.doc.eq(prevState.doc) || !view.state.selection.eq(prevState.selection)) {
this.closePopup();
}
},
destroy: () => {
this.closePopup();
Expand Down