Conversation
|
Sure, its shows possession, while it's is a contraction. In any event, it might be a cleaner commit history if a soft reset was performed. |
|
Can merging be postponed? I have a few more changes not the least of which are the below. I'll write up a shell script with GNU One should be careful with considering typos in changelogs as sometimes they appear in the description of a PR. Additionally |
8d2caea to
79b8be5
Compare
|
By the way are contributor's expected to sign a CLA? @lbm364dl I suppose you have access to a GNU These are just some example lines, not yet the promised shell script with the entirety of the suggested fixes. Expected |
|
How do you find the typos? I don't think it's just you searching random words, is it? |
|
For this Issue my comments pertain exclusively to the docs subdirectory. I had cloned the repository and dumped strings from the docs subdirectory.
One can then filter out using whatever language one prefers certain strings resulting is a considerably smaller file. |
|
I added the other fixes you suggested. For the changelog ones I checked that the messages weren't part of the linked PR, so it should be fine. |
|
My personal preference which does not necessarily express the consensus of the Developers/Maintainers is where textual changes are to be implemented within a markdown table thereby obliging table adjustment, then the adjustment might as well align that table.
Separately there's another location where it's as a contraction is mistakenly present rather than its showing possession. |
I think the common approach is to not change lines that are not directly related to your PR (thus adding the space instead of removing one from all lines), but I can fix them if necessary, of course. I agree, let's let maintainers decide.
Somehow I missed that one, thank you. |
|
Thanks for the PR! (No, we're not going to delay merging this, because these are already good improvements.) (For sufficiently large contributions we do expect a signed CLA. We consider fixing typos valuable, but don't consider a CLA necessary in this case.) |
(cherry picked from commit 6cdab90)
|
Successfully created backport PR for |
|
Perhaps there are some typos here or in the successor #1740 which could be added to the codespell corpus. |
No apostrophe when used as pronoun. I think I checked the whole project.